Returning multiple values in a for loop?

Question

so long story short:

import random

cards = [11, 2, 3, 4, 5, 6, 7, 8, 9, 10, 10, 10, 10]
user_hand = []
computer_hand = []

def draw(x):
  for c in range(0, x):
    card = random.choice(cards)
  return card

user_hand.append(draw(1))
    
print(user_hand)

Trying to get a function together that will loop through the cards list and pick a random item, however many times as specified by X, however no matter the number plugged into

user_hand.append(draw(x))

it always returns only 1 card, quite stumped. Any ideas? Thought it was the return in the function as return ends a code block when it's called but i wasn't sure.

Put user_hand.append(random.choice(cards)) instead of card = random.choice(cards). Then call draw(x) without to append part. However, this will draw cards with replacement, I am not sure if this is what you want to do. — Diego Palacios
– Diego Palacios, Commented Mar 18, 2021 at 10:54

Krishna Chaurasia · Accepted Answer · 2021-03-18 10:54:52Z

1

It is because card is getting overwritten in each iteration and you only return the last value.

You can create a list and return the list instead:

def draw(x):
  random_cards = []
  for c in range(0, x):
    card = random.choice(cards)
    random_cards.append(card)
  return random_cards

user_hand.extend(draw(1))  # further you'll need extend here else it will create a list of lists

answered Mar 18, 2021 at 10:54

Krishna Chaurasia

9,6546 gold badges27 silver badges44 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Alexey · Accepted Answer · 2021-03-18 10:59:32Z

0

May be this way

def draw(x):
  result=[] 
  for c in range(0, x):
     card = random.choice(cards)
     result.append(card) 
return result

answered Mar 18, 2021 at 10:59

Alexey

4163 silver badges9 bronze badges

Comments

Altareos · Accepted Answer · 2021-03-18 11:02:33Z

0

If you want to pick cards without replacement, the random.sample function does what you want.

def draw(x):
  return random.sample(cards, x)

user_hand.extend(draw(3))

answered Mar 18, 2021 at 11:02

Altareos

8816 silver badges14 bronze badges

Comments

Onkar Raut · Accepted Answer · 2021-03-18 11:06:59Z

0

Problem lies in the value you are passing to draw() as range function iterates over the start and end point so passing one will return you only one value!
You also need to add another list to append the random choices selected during range()

answered Mar 18, 2021 at 11:06

Onkar Raut

12 bronze badges

Collectives™ on Stack Overflow

Returning multiple values in a for loop?

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related