Using RelayCommand to add item to ListView

Question

I'm practicing MVVM by create a simple ListView and a Button. When Button is clicked, a new item will be added to ListView. However my implementation doesn't work. I'm using RelayCommand for the Button. What did I do wrong?

XAML

   <Grid>
        <Grid.RowDefinitions>
            <RowDefinition Height="Auto"></RowDefinition>
            <RowDefinition></RowDefinition>
        </Grid.RowDefinitions>
        <Button x:Name="AddButton" Grid.Row="0" Margin="10" Content="Add Item"  Command="{Binding AddCommand}" />
        
        <ListView x:Name="ListViewItems" Grid.Row="1" Margin="10" ItemsSource="{Binding Items}">
            <ListView.ItemContainerStyle >
                <Style TargetType="ListViewItem">
                    <Setter Property="HorizontalContentAlignment" Value="Stretch"/>
                </Style>
            </ListView.ItemContainerStyle>
            
            <ListView.ItemTemplate>
                <DataTemplate>
                    <TextBox x:Name="Input" FontSize="15"></TextBox>
                </DataTemplate>
            </ListView.ItemTemplate>
        </ListView>
    </Grid>

ListViewModel

public class ListViewModel : INotifyPropertyChanged
    {
        private ObservableCollection<ItemModel> items;

        public ObservableCollection<ItemModel> Items {
            get
            {
                return this.items;
            }

            set
            {
                if (items != value)
                {
                    items = value;
                    RaisePropertyChanged(nameof(items));
                }
            } 
        }

        #region Constructor
        public ListViewModel()
        {
            AddCommand = new RelayCommand(
                ExecuteCommand);
        }
        #endregion

        #region Button command
        public RelayCommand AddCommand;

        private void ExecuteCommand()
        {
            items.Add(new ItemModel());
        }

        #endregion

        #region INotify
        public event PropertyChangedEventHandler PropertyChanged;

        public void RaisePropertyChanged(string property)
        {
            PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(property));
        }
        #endregion
    }

Main Window

 public partial class MainWindow : Window
    {
        public MainWindow()
        {
            InitializeComponent();
            this.DataContext = new ListViewModel();
        }
    }

Hint: look into output window, binding errors there are the first sign you did something wrong. — Sinatr
– Sinatr, Commented Mar 29, 2021 at 9:10
@ASh I edited the post. The DataContext is set in the MainWindow class — Tống Việt Dũng
– Tống Việt Dũng, Commented Mar 29, 2021 at 9:52
@Sinatr Oh I see the binding error. But I did have a public RelayCommand AddCommand; declared — Tống Việt Dũng
– Tống Việt Dũng, Commented Mar 29, 2021 at 9:53

ASh · Accepted Answer · 2021-03-29 09:53:47Z

3

AddCommand should be a property:

public RelayCommand AddCommand { get; }

Currently it is declared as field (no getter).

see Why does WPF support binding to properties of an object, but not fields?

answered Mar 29, 2021 at 9:53

ASh

35.9k9 gold badges68 silver badges89 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Using RelayCommand to add item to ListView

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related