How to break this loop? (python)

Question

    available_fruits = ['apple', 'grape', 'banana']
    
    choice = input('Please pick a fruit I have available: ')
    
    while True : choice= input('You made an invalid choice. Please pick again:') 
            if choice not in available_fruits 
                 else print('You can have the fruit')

I want to make this loop stop when user inputs something in the list "available_fruits". But when I enter 'apple', it says "You can have the fruit" but as well as "You made an invalid choice. Please pick again:" again.

How can I make this loop to stop when I enter the fruit which is in the list? when I put the "break" at the end of the code, it says its an invalid syntax..

That code is not (valid) Python, where indentation matters. Please extract a minimal reproducible example and provide that as part of your question, so people don't have to guess what the code is that causes problems. As a new user, also take the tour and read How to Ask. — Ulrich Eckhardt
– Ulrich Eckhardt, Commented Apr 6, 2021 at 19:01

Ulises Torrella · Accepted Answer · 2021-04-06 19:03:33Z

3

Use the while condition instead of just while True, something like this works:

available_fruits = ['apple', 'grape', 'banana']

choice = input('Please pick a fruit I have available: ')

while choice not in available_fruits: 
    choice= input('You made an invalid choice. Please pick again:')

print('You can have the fruit')

answered Apr 6, 2021 at 19:03

Ulises Torrella

2953 silver badges8 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Padmina · Accepted Answer · 2021-04-06 19:14:27Z

2

This would work:

available_fruits = ['apple', 'grape', 'banana']

choice = input('Please pick a fruit I have available: ')

while True:
    if choice in available_fruits:
        print('You can have the fruit')
        break
    else:
        choice = input('You made an invalid choice. Please pick again: ')

But in general I'd suggest you create while loops with an actual condition. That's what while-loops are for. They automatically break when the condition evaluates to False. It's much cleaner, too.

Example:

available_fruits = ['apple', 'grape', 'banana']

choice = input('Please pick a fruit I have available: ')

while choice not in available_fruits:
    choice = input('You made an invalid choice. Please pick again: ')

print('You can have the fruit')

edited Apr 6, 2021 at 19:14

answered Apr 6, 2021 at 19:03

Padmina

1238 bronze badges

2 Comments

0x5453 Over a year ago

This still complains about making an invalid choice on the first iteration of the loop.

Padmina Over a year ago

thank you, you're right :D I edited the code.

Thavas Antonio · Accepted Answer · 2021-04-06 19:06:48Z

1

Give this a try. Assuming you need to use break.

available_fruits = ['apple', 'grape', 'banana']

choice = input('choose a fruit: ')
while True : 
    if choice in available_fruits:
        print('you picked a valid fruit')
        break
    else:
        choice = input('choose a fruit: ')

answered Apr 6, 2021 at 19:06

Thavas Antonio

5,9091 gold badge19 silver badges51 bronze badges

Comments

pazitos10 · Accepted Answer · 2021-04-07 17:11:17Z

1

I don't know if its the formatting of your question of if that's your actual code. You some have syntax errors:

At the end of every if or else you need to use : as you did with the while condition.
You must use the correct indentation.

Once you fix those errors, check the condition you want to meet in order to get out of the loop with break.

edited Apr 7, 2021 at 17:11

answered Apr 6, 2021 at 19:09

pazitos10

1,70416 silver badges25 bronze badges

Collectives™ on Stack Overflow

How to break this loop? (python)

4 Answers 4

Comments

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related