Get IP address using domain in text file in python

Question

I have a text file contains domains and IPs, I want to get the IP using the domain name but it returns null.

Here is my code:

import json
import os
import sys
import pathlib
import platform
HERE = pathlib.Path(__file__).parent
def clean_server_names(name):
    server_names_list = [x.lower().strip() for x in
                            open(HERE / "servers" / "myservers.txt", 'r').readlines()]
    for server in server_names_list:
        domain_name_and_code = server.split(' ')
        domain = domain_name_and_code[0].strip()
        ip = domain_name_and_code[-1].strip()
        if name ==  domain:
            print(ip)
clean_server_names("domain1.nordvpn.com ")

Here's what inside my text file.

domain1.nordvpn.com 192.168.1.1

pls check your if condition if name == domain: how is the name initialized ? name still contains domain1.nordvpn.com 192.168.1.1. so equal will not work. — simpleApp
– simpleApp, Commented May 6, 2021 at 15:29
yes, pls. you have space in name clean_server_names("domain1.nordvpn.com ") see the last space after .com. so you can either remove space when you pass the parameter or strip the space ` if name.strip() == domain:` — simpleApp
– simpleApp, Commented May 6, 2021 at 16:07
I already put the strip, but still not working, Please help me — Kleto Ralph Salvo
– Kleto Ralph Salvo, Commented May 6, 2021 at 16:12

keithpjolley · Accepted Answer · 2021-05-26 16:05:08Z

1

You have a lot of code in there that's not needed and is cluttering up what your intent is.

$ cat ./x.py                                                                                                                   
#! /usr/bin/env python3
# -*- coding: UTF8 -*-

def clean_server_names(name):
    with open("servers/myservers.txt", "r") as f:
        for line in f:
            domain_name, ip = line.lower().split()
            if name == domain_name:
                print(ip)

clean_server_names("domain1.nordvpn.com")

$ cat ./servers/myservers.txt                                                                                                  
domain1.nordvpn.com 192.168.1.1

$ ./x.py                                                                                                                       
192.168.1.1

Simpler:

$ awk '$1 == "domain1.nordvpn.com"{print $2}' servers/myservers.txt
192.168.1.1

edited May 26, 2021 at 16:05

answered May 6, 2021 at 15:50

keithpjolley

2,2931 gold badge20 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Kleto Ralph Salvo Over a year ago

still not working, but thanks for the help

Kleto Ralph Salvo Over a year ago

it retuns like this ['\x00c\x00h\x003\x001\x008\x00.\x00n\x00o\x00r\x00d\x00v\x00p\x00n\x00.\x00c\x00o\x00m\x00', '\x008\x009\x00.\x001\x008\x007\x00.\x001\x006\x005\x00.\x003\x009\x00'] ['\x00'] ['\x00']

keithpjolley Over a year ago

updating to show exactly what's in there and the output.

Collectives™ on Stack Overflow

Get IP address using domain in text file in python

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related