Javascript filter not working for multiple condition

Question

I am trying to filter array of objects on the basis of some conditions. If I apply single condition it works but if I applied some more condition it doesn't worked!!. I don't understand why its not working for multiple conditions.Below is my code.

const removeItemIfConditationMatch = () => {
  let filter = [];
  filter = arr.filter(
    item => item.id !== myObj.id && 
    item.level !== myObj.level && 
    item.technology !== myObj.technology && 
    item.type !== myObj.type)
  console.log(filter)
}

let myObj = {
  "questions": [],
  "technology": "Can_Js",
  "type": "NON_CODE",
  "level": "EASY",
  "id": 0
}
let arr = [{
    "questions": [],
    "technology": "Can_Js",
    "type": "NON_CODE",
    "level": "EASY",
    "id": 0
  },
  {
    "questions": [],
    "technology": "Network_Simulator",
    "type": "NON_CODE",
    "level": "EASY",
    "id": 1
  },
  {
    "questions": [],
    "technology": "Java",
    "type": "NON_CODE",
    "level": "HIGH",
    "id": 0
  },
  {
    "questions": [],
    "technology": "Java",
    "type": "CODE",
    "level": "HIGH",
    "id": 1
  },
  {
    "questions": [],
    "technology": "React Js",
    "type": "NON_CODE",
    "level": "MEDIUM",
    "id": 1
  }
]
removeItemIfConditationMatch()

In the above code if I filter on single condition it works but if you run above code it won't work. Anyone have any idea why Its not working where I am doing wrong. Any help will be appreciated.

After applying my multi filter criteria I am expecting below result.

[
    {
        "questions": [],
        "technology": "Network_Simulator",
        "type": "NON_CODE",
        "level": "EASY",
        "id": 1
    },
    {
        "questions": [],
        "technology": "Java",
        "type": "NON_CODE",
        "level": "HIGH",
        "id": 0
    },
    {
        "questions": [],
        "technology": "Java",
        "type": "CODE",
        "level": "HIGH",
        "id": 1
    },
    {
        "questions": [],
        "technology": "React Js",
        "type": "NON_CODE",
        "level": "MEDIUM",
        "id": 1
    }
]

In short I am expecting if my condition match then remove that Object from array list.

agershun · Accepted Answer · 2021-06-09 07:50:49Z

4

Try to replace the condition to:

filter = arr.filter(item => !(item.id == myObj.id &&
                    item.level == myObj.level && 
                    item.technology == myObj.technology && 
                    item.type == myObj.type))

In your code the original filter removes all objects where ANY field equals to the value in myObj object. In suggested code filter function removes objects where ALL fields are not equal to the fields in myObj.

The problem is here: if you want to remove value from an array with the condition:

   item.id !== myObj.id && item.level !== myObj.level ...

if id fields are not equal then JS stops to verify the condition and drops this element from the result array.

edited Jun 9, 2021 at 7:50

answered Jun 9, 2021 at 7:37

agershun

4,10742 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Steve · Accepted Answer · 2021-06-09 07:40:10Z

1

const removeItemIfConditationMatch = () => {
  let filter = [];
  filter = arr.filter(
    item => item.id !== myObj.id || 
    item.level !== myObj.level || 
    item.technology !== myObj.technology || 
    item.type !== myObj.type)
  console.log(filter)
}

let myObj = {
  "questions": [],
  "technology": "Can_Js",
  "type": "NON_CODE",
  "level": "EASY",
  "id": 0
}
let arr = [{
    "questions": [],
    "technology": "Can_Js",
    "type": "NON_CODE",
    "level": "EASY",
    "id": 0
  },
  {
    "questions": [],
    "technology": "Network_Simulator",
    "type": "NON_CODE",
    "level": "EASY",
    "id": 1
  },
  {
    "questions": [],
    "technology": "Java",
    "type": "NON_CODE",
    "level": "HIGH",
    "id": 0
  },
  {
    "questions": [],
    "technology": "Java",
    "type": "CODE",
    "level": "HIGH",
    "id": 1
  },
  {
    "questions": [],
    "technology": "React Js",
    "type": "NON_CODE",
    "level": "MEDIUM",
    "id": 1
  }
]
removeItemIfConditationMatch()

answered Jun 9, 2021 at 7:40

Steve

1,9531 gold badge13 silver badges14 bronze badges

1 Comment

Steve Over a year ago

You are using && but I think you mean to use || or. developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/…

Long Vu · Accepted Answer · 2021-06-09 07:40:51Z

const removeItemIfConditationMatch = () => {
  let filter = [];
  let myObj = {
    questions: [],
    technology: "Can_Js",
    type: "NON_CODE",
    level: "EASY",
    id: 0,
  };
  let arr = [
    {
      questions: [],
      technology: "Can_Js",
      type: "NON_CODE",
      level: "EASY",
      id: 0,
    },
    {
      questions: [],
      technology: "Network_Simulator",
      type: "NON_CODE",
      level: "EASY",
      id: 1,
    },
    {
      questions: [],
      technology: "Java",
      type: "NON_CODE",
      level: "HIGH",
      id: 0,
    },
    {
      questions: [],
      technology: "Java",
      type: "CODE",
      level: "HIGH",
      id: 1,
    },
    {
      questions: [],
      technology: "React Js",
      type: "NON_CODE",
      level: "MEDIUM",
      id: 1,
    },
  ];
  filter = arr.filter(
    (item) =>
      item.id !== myObj.id ||
      item.level !== myObj.level ||
      item.technology !== myObj.technology ||
      item.type !== myObj.type
  );
  console.log(filter);
};

removeItemIfConditationMatch();

Prebiusta · Accepted Answer · 2021-06-09 07:43:59Z

0

Try to use this filter instead

arr.filter((item) => JSON.stringify(item) !== JSON.stringify(myObj));

Remember that in your solution you specified multiple conditions, which usually have unexpected behavior in JavaScript. Logic is inverted, therefore you would have to use || instead of &&

answered Jun 9, 2021 at 7:43

Prebiusta

4713 silver badges15 bronze badges

Collectives™ on Stack Overflow

Javascript filter not working for multiple condition

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related