Remove item / data from Json file with Python

Question

I have the following .json file named weapons.json:

{
  "weapons": [
    {
      "game": "EMPTY",
      "weapon": "EMPTY",
      "down": "0",
      "up": "0",
      "left": "0",
      "right": "0"
    },
    {
      "game": "DELETE",
      "weapon": "DELETE",
      "down": "0",
      "up": "0",
      "left": "0",
      "right": "0"
    }
  ]
}

This data is only for testing.

From this file I want to remove the second item :

{
  "game": "DELETE",
  "weapon": "DELETE",
  "down": "0",
  "up": "0",
  "left": "0",
  "right": "0"
}

For this, I have tried the following function:

#Deleting json info from the selected weapon
def deleteWeapon():
        with open('json/weapons.json') as info:
                weapons_dict =  json.load(info)
        
        for weapon in weapons_dict['weapons']:
                if (weapon['game']=="DELETE" and weapon['weapon']=="DELETE" and weapon['down']=="0" and weapon['up']=="0" and weapon['left']=="0" and weapon['right']=="0"):
                        del weapon
                        
        with open('json/weapons.json','w') as remove:
                json.dump(weapons_dict,remove,indent=2)
                
deleteWeapon()

Where I try to do a del weapon to remove the value, but this does not work. I have also tried doing del weapon['XXX'] del weapon['XXX'] with all item values, but doing this the .json looks like this.

{
  "weapons": [
    {
      "game": "EMPTY",
      "weapon": "EMPTY",
      "down": "0",
      "up": "0",
      "left": "0",
      "right": "0"
    },
    {}
  ]
}

Instead of :

{
  "weapons": [
    {
      "game": "EMPTY",
      "weapon": "EMPTY",
      "down": "0",
      "up": "0",
      "left": "0",
      "right": "0"
    }
  ]
}

I am grateful to hear any help.

Try to use weapons_dict['weapons'].pop(weapon) instead of 'del weapon' — Wimanicesir
– Wimanicesir, Commented Sep 15, 2021 at 13:54
@Wimanicesir I don't think it's safe to remove items from a list that you are currently iterating. Also I think that .pop(weapon) will fail as weapon isn't an int. I think you meant .remove(weapon) — TheLizzard
– TheLizzard, Commented Sep 15, 2021 at 13:58
@Alexci Please remove the tkinter tag from the question as the question isn't directly linked to tkinter. — TheLizzard
– TheLizzard, Commented Sep 15, 2021 at 13:59

TheLizzard · Accepted Answer · 2021-09-15 14:20:19Z

1

Try this:

weapons = list(weapons_dict["weapons"])
for i, weapon in enumerate(weapons):
    if (weapon['game']=="DELETE" and weapon['weapon']=="DELETE" and weapon['down']=="0" and weapon['up']=="0" and weapon['left']=="0" and weapon['right']=="0"):
        del weapons_dict["weapons"][i]

That iterate over the list using i as the current index and then it will call del weapons_dict["weapons"][i] when ever it needs to delete that weapon.

edited Sep 15, 2021 at 14:20

answered Sep 15, 2021 at 13:55

TheLizzard

7,8002 gold badges16 silver badges43 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

RuthIsRoot Over a year ago

Nope, still don't remove the value.

TheLizzard Over a year ago

@Alexci Btw I fixed the problem.

RuthIsRoot Over a year ago

Yep, it's fixed, your solution remove data from json, also mine remove data from json and directly from my Treeview.

RuthIsRoot · Accepted Answer · 2021-09-15 14:17:34Z

1

Already found the solution.

The code should look like this :

def deleteWeapon():
        with open('json/weapons.json') as info:
                weapons_dict =  json.load(info)
        
        weapons = list(weapons_dict["weapons"])
        for i, weapon in enumerate(weapons):
                if (weapon['game']=="DELETE" and weapon['weapon']=="DELETE" and weapon['down']=="0" and weapon['up']=="0" and weapon['left']=="0" and weapon['right']=="0"):
                        weapons_dict['weapons'].pop(i)
                        
        with open('json/weapons.json','w') as remove:
                json.dump(weapons_dict,remove,indent=2)

answered Sep 15, 2021 at 14:17

RuthIsRoot

1422 silver badges10 bronze badges

Collectives™ on Stack Overflow

Remove item / data from Json file with Python

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related