Create Web server using Node js model MVC

Question

I'm trying to create a web server, and I'm using to MVC model so I tried to use routes inside so I don't know how can I do this. in the console log thats return all data otherwise in postman I test it it doesn't works. here is my code.

AirModel.js :

AirMonitoring.getAllData = (result) =>{
    db.query('SELECT * FROM AirMonitoring', (err, res)=>{
        if(err){
            console.log('Error while fetching airMonitoring', err);
            result(null,err);
        }else{
            console.log('AirMonitoring fetched successfully');
            result(null,res);
        }
    })
}

airController.js :

exports.getAllData = (req, res)=> {
        AirModel.getAllData((err, airMonitoring) =>{
            if(err)
            res.send(err);
            console.log('data', airMonitoring);
            res.send(airMonitoring)
        })
    }

index.js :

const server = http.createServer(function(req, res) {
console.log("http was created!");

  if(req.url == '/airMonitoring'){
    res.writeHead(200, { 'Content-Type': 'application/json' });
      // get latest record of airMonitoring 
     router.get('/airMonitoring', airController.getAllData);
    
    res.end();  
}
});

I'm a little confused regarding your code... In the actual db.query, you're not doing anything with the data other than logging it to the console. Why would you expect anything otherwise? — silencedogood
– silencedogood, Commented Oct 28, 2021 at 13:14
Yeah I'm connecting with raspberry db, and with the AirModel there is a query getting the data from db so nothing return from the controller I used in routes, why?! — Keltouma Indtaher
– Keltouma Indtaher, Commented Oct 28, 2021 at 13:19
I'm assuming the db.connect code is in your AirModel?? If so, look at the code, you're not returning any of the data, or even assigning it for that matter. You're just logging it to the console. That's why it's not returning anything... Show a little more of your code the surrounds the db.connect bit, so I can be sure this is what's happening, and I can give you a working example. — silencedogood
– silencedogood, Commented Oct 28, 2021 at 13:23

php_nub_qq · Accepted Answer · 2021-10-28 13:50:08Z

1

It's not very clear what router is but I'm assuming it's an express router, and that's not how routing works. Currently you are (re?)defining the route on each request. The routing page is a good place to start, but basically you need to define the routes once.

var express = require('express')
var app = express()

app.get('/airMonitoring', airController.getAllData);

app.listen(PORT, () => {
  console.log(`Example app listening at http://localhost:${PORT}`)
})

And also in your AirModel.js you have an error as far as I can tell, when handling the database error you should provide it as first argument, not second:

result(null,err); /* has to be result(err, null) */

answered Oct 28, 2021 at 13:50

php_nub_qq

16.1k25 gold badges84 silver badges150 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

silencedogood Over a year ago

This is almost certainly the problem. I looked right passed the fact that the route was nested in an if...

php_nub_qq Over a year ago

Not only is it within the request handler, but also nothing is using the router, so even if it were defined properly it would still not make a difference.

silencedogood Over a year ago

Unless that code was left out of the OP, like much of the code was to begin with. But yes, you are right.

Collectives™ on Stack Overflow

Create Web server using Node js model MVC

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related