Cannot insert data into SQL Server from Windows form

Question

I'm creating a window form that displays a Calendar Event.

And when I add an event on specific date, I get this error:

System.Data.SqlClient.SqlException: 'Incorrect syntax near 'value'

at the line cmd.ExecuteNonQuery();.

This is my code:

namespace PRN_Project
{
    public partial class EventForm : Form
    {
        String ConnectionString = "server=DESKTOP-7NUQVBN; database=Calendar; uid=sa; pwd=123";

        public EventForm()
        {
            InitializeComponent();
        }

        private void EventForm_Load(object sender, EventArgs e)
        {
            tbDate.Text = UserControlDays.static_day + "/" + CalendarForm.static_month + "/" + CalendarForm.static_year;
        }

        private void btSave_Click(object sender, EventArgs e)
        {
            SqlConnection conn = new SqlConnection(ConnectionString);
            conn.Open();
            String sql = "INSERT INTO CalendarEvent (TimeDate, EventName) VALUE (?, ?)";

            SqlCommand cmd = conn.CreateCommand();
            cmd.CommandText = sql;
            cmd.Parameters.AddWithValue("TimeDate", tbDate.Text);
            cmd.Parameters.AddWithValue("EventName", tbEvent.Text);

            cmd.ExecuteNonQuery();

            MessageBox.Show("Saved!");

            cmd.Dispose();
            conn.Close();
        }
    }
}

I am using SQL Server authentication.

The datatype for TimeDate and EventName is varchar(255).

VALUES not VALUE. INSERT INTO TABLE_NAME VALUES (COLUMN_1, COLUMN2) — Yong Shun
– Yong Shun, Commented Nov 7, 2021 at 4:51
VALUES not VALUE. And you should ideally use named parameters INSERT INTO CalendarEvent(TimeDate, EventName) values (@TimeDate, EventName). Also note: AddWithValue is Evil, specify parameter types and lengths explicitly. And you need using blocks on the connection and command objects — Charlieface
– Charlieface, Commented Nov 7, 2021 at 4:55
@Charlieface can you explain specific for me please, i m new to this — Xjodia
– Xjodia, Commented Nov 7, 2021 at 5:05

AliNajafZadeh · Accepted Answer · 2021-11-07 05:13:11Z

1

try this one:

private void btSave_Click(object sender, EventArgs e)
        {
            SqlConnection conn = new SqlConnection(ConnectionString);
            String sql = "INSERT INTO CalendarEvent(TimeDate, EventName)values(@TimeDate,@EventName)";
            SqlCommand cmd = new SqlCommand();
            cmd.Connection = conn;
            cmd.CommandType = CommandType.Text;
            cmd.CommandText = sql;
            cmd.Parameters.AddWithValue("@TimeDate", tbDate.Text);
            cmd.Parameters.AddWithValue("@EventName", tbEvent.Text);
            conn.Open();
            cmd.ExecuteNonQuery();
            MessageBox.Show("Saved !!!");
            cmd.Dispose();
            conn.Close();
        }

and you can use TRY Catch Finally

private void btSave_Click(object sender, EventArgs e)
            {
                SqlConnection conn = new SqlConnection(ConnectionString);
                String sql = "INSERT INTO CalendarEvent(TimeDate, EventName)values(@TimeDate,@EventName)";
                SqlCommand cmd = new SqlCommand();
                cmd.Connection = conn;
                cmd.CommandType = CommandType.Text;
                cmd.CommandText = sql;
                cmd.Parameters.AddWithValue("@TimeDate", tbDate.Text);
                cmd.Parameters.AddWithValue("@EventName", tbEvent.Text);
            try
            {
                conn.Open();
                cmd.ExecuteNonQuery();
                MessageBox.Show("Saved !!!");
            }
            catch
            {
            }
            finally
            {
                conn.Close();
            }
                
                
                
    }

edited Nov 7, 2021 at 5:13

answered Nov 7, 2021 at 5:03

AliNajafZadeh

1,3342 gold badges15 silver badges26 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Klaus Gütter Over a year ago

Instead of the try..catch--finally, just use using (SqlConnection conn = new SqlConnection(ConnectionString)) { ... }

AliNajafZadeh Over a year ago

@Klaus Gütter thanks. and your way is another good way and good idea.

Collectives™ on Stack Overflow

Cannot insert data into SQL Server from Windows form

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related