jQuery Deleting Button from jQuery UI Error

Question

I am trying to add the remove buttons dynamically from a jQuery UI Dialog, however my remove function appears to be causing the below error:

Uncaught TypeError: Cannot read property 'length' of undefined
jquery-1.5.2.min.js:16

I am not really sure why, but if I comment out my use of the remove button function everything works ok. I have uploaded a basic copy: http://jsfiddle.net/fS253/6/ but dialog doesn't appear to work within jsfiddle

// Allows simple button addition to a ui dialog
$.extend($.ui.dialog.prototype, {
    'addbutton': function (buttonName, func) {
        var buttons = this.element.dialog('option', 'buttons');
        buttons.push({text: buttonName, click: func});
        this.element.dialog('option', 'buttons', buttons);
    }
});

// Allows simple button removal from a ui dialog
$.extend($.ui.dialog.prototype, {
    'removebutton': function (buttonName) {
        var buttons = this.element.dialog('option', 'buttons');

        for (var i in buttons) {
          if(buttons[i].text==buttonName) {
            delete buttons[i];
          }
        }

        this.element.dialog('option', 'buttons', buttons);
    }
}); 

actionsForm.dialog('addbutton', 'New Button', newButtonClickFunction); 
actionsForm.dialog('removebutton', 'New Button');

function newButtonClickFunction() { 
    alert('You clicked the new button!'); 
}

It's not working on jsfiddle because you didn't include the necessary jQuery UI CSS file. Here's an updated version jsfiddle.net/fS253/3 — Lance
– Lance, Commented Aug 12, 2011 at 15:17

Janis · Accepted Answer · 2011-08-12 15:41:01Z

3

The problem is that delete buttons[i]; removes element but still keeps the array length same.

Simple solution would be to create a new array - http://jsfiddle.net/m3a7a/

answered Aug 12, 2011 at 15:41

Janis

8,7991 gold badge24 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Pez Cuckow Over a year ago

I always forget the simple things... Thanks! Using if(i!=-1) buttons.splice(i, 1); now

Collectives™ on Stack Overflow

jQuery Deleting Button from jQuery UI Error

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related