Input string was not in a correct format. Textbox value

Question

I have this method.

public static long? GetPayments(int PaymentId,string Reference)
        
{

          
            try
            {
                using (SqlConnection con = new SqlConnection(connstrig))
                {
                    con.Open();
                    DynamicParameters param = new DynamicParameters();
                    param.Add("@IDPayment", PaymentId);
                    param.Add("@Ref", Reference);
                    var result = con.Query<long?>("spc_PaymentStatusForCombo", param, commandType: CommandType.StoredProcedure).FirstOrDefault();
                    return result;
                }
            }
            catch (Exception exc)
            {
                ApplicationLog.WriteLog("spc_PaymentStatusForCombo", exc.Message, "Error");
                return null;
            }
        }

And when i call it this error is shown up:Input string was not in a correct format.

var result = 
GetPaymentsByPayId(Convert.ToInt32(txt_IdPayment.Text.Trim()), (txt_IdPayment.Text.Length > 0) ? (txt_OrderID.Text.Trim()) : string.Empty);

Can you help me please? Thank you

is this a Win Forms app?, do you call this function in TextChanged Event ? — Mahmoud Farahat
– Mahmoud Farahat, Commented Dec 28, 2021 at 13:05
yes it is a win form. No i call it in a method, which then i call in click of an button — DevGirl
– DevGirl, Commented Dec 28, 2021 at 13:17
the only thing I can think about is that txt_IdPayment.Text, try to debug your code and check the value of txt_IdPayment.Text — Mahmoud Farahat
– Mahmoud Farahat, Commented Dec 28, 2021 at 13:32

Coskun Ozogul · Accepted Answer · 2021-12-28 12:55:36Z

1

The error is clear, the string input is not correct.

You can have this error for example if you try Convert.ToInt32("");

According to your method's structure, you should send an int value as the first parameter and the Convert.ToInt32(txt_IdPayment.Text.Trim()) must cause this exception.

Check what it returns txt_IdPayment.Text.Trim().

answered Dec 28, 2021 at 12:55

Coskun Ozogul

2,5172 gold badges25 silver badges37 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

DevGirl Over a year ago

txt_IdPayment.Text.Trim() without Convert.ToInt32 shows error

Coskun Ozogul Over a year ago

Weird! Are you sure?

DevGirl Over a year ago

yeah i tried now again. If i delete Convert.ToInt32 it shows the error can not convert from string to int

Coskun Ozogul Over a year ago

No, this is another error. If you send a string to your method, you will have this exception. Can you try to get it in a parameter before calling your method ? For example var id = txt_IdPayment.Text.Trim();

DevGirl Over a year ago

thank you. When i did this var id, it worked.

Amit · Accepted Answer · 2021-12-28 13:03:15Z

0

var result = GetPaymentsByPayIdorMidasreference(Convert.ToInt32((txt_IdPayment.Text.Length > 0) ? txt_IdPayment.Text.Trim() : "0"), (txt_IdPayment.Text.Length > 0) ? (txt_OrderID.Text.Trim()) : string.Empty);

answered Dec 28, 2021 at 13:03

Amit

8237 silver badges13 bronze badges

3 Comments

Coskun Ozogul Over a year ago

This is not a good solution Amit. In case of something nonconvertible to int you will get the same error. For example, if the input text is ABC, you will have the same error and if the length is 0, you will get a false result. You should check what you send to your method before.

Amit Over a year ago

If we restrict our input type to accept only numeric value then it will work.

Coskun Ozogul Over a year ago

Yes but, you can not restrict the textbox without a specific code. And we don't know the context and where the ID comes from into the textbox.

Collectives™ on Stack Overflow

Input string was not in a correct format. Textbox value

2 Answers 2

5 Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related