Multiple If - else in php

Question

My PHP code looks like that.

if(isset($_GET['id'])) {
    $id = $_GET['id'];
}
if(isset($_GET['subid'])) {
    $subid = $_GET['subid'];
}

I want to get variable if isset and set to 0 if !isset. something like that

if(isset($_GET['id'])) {
    $id = $_GET['id'];
} else $id='0';

But as you see i have multiple if's. How can i do it? I need to write else for every if?

UPDATE Ok. thx for your help. I did it. But is there any way to shorten this piece of code again?

$id = isset($_GET['id']) ? $_GET['id'] : 0;
$page = isset($_GET['page']) ? $_GET['page'] : 0;
$subid = isset($_GET['subid']) ? $_GET['subid'] : 0;
$feat = isset($_GET['feat']) ? $_GET['feat'] : 0;

Pehmolelu · Accepted Answer · 2011-08-22 10:30:32Z

4

$id = isset($_GET['id']) ? $_GET['id'] : 0;

answered Aug 22, 2011 at 10:30

Pehmolelu

3,5662 gold badges28 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Pehmolelu Over a year ago

@Tural, I then suggest looking at the foreach solution that Arjan has already given.

JSantos · Accepted Answer · 2011-08-22 10:32:16Z

3

$id = $subid=0;

if(isset($_GET['id']))
{
$id = $_GET['id'];
}
if(isset($_GET['subid']))
{
$subid = $_GET['subid'];
}

you can initiate all variables at 0 before you run that code

edited Aug 22, 2011 at 10:32

answered Aug 22, 2011 at 10:28

JSantos

1,70822 silver badges40 bronze badges

2 Comments

Prisoner Over a year ago

If you're going about it that way, might as well do: $id = $subid = 0

JSantos Over a year ago

Can't think of anyway to make it significantly shorter

Polity · Accepted Answer · 2011-08-22 10:35:10Z

2

use a helper function:

function getQSValueOrDefault($name, $default){
   if (!isset($_GET[$name]))
      return $default;
   else
      return $_GET[$name];
}

and use it like:

$id = getQSValueOrDefault('id', 0); 
$subid = getQSValueOrDefault('subid', 0);

edited Aug 22, 2011 at 10:35

answered Aug 22, 2011 at 10:29

Polity

15.4k2 gold badges43 silver badges42 bronze badges

1 Comment

Bob Vale Over a year ago

This could be simplified slightly using the ?: syntax

Arnaud Le Blanc · Accepted Answer · 2011-08-22 10:29:49Z

1

The shortest way to get an input variable is the following:

$id = filter_input(INPUT_GET, 'id');

(you don't have to check if the value is set)

Other method:

// set default values if they are not set
// so that you don't have to check if they are set
$inputs = $_GET + array(
    'id' => 0,
    'subid' => 0,
);

$id = $inputs['id'];
$subid = $inputs['subid'];

Or using ternary operator:

$id = isset($_GET['id']) ? $_GET['id'] : 0;
$subid = isset($_GET['subid']) ? $_GET['subid'] : 0;

answered Aug 22, 2011 at 10:29

Arnaud Le Blanc

100k24 gold badges211 silver badges196 bronze badges

1 Comment

Arnaud Le Blanc Over a year ago

The first and second methods I proposed are both shorted than the code you want to shorten.

Prisoner · Accepted Answer · 2011-08-22 10:30:45Z

1

$id = isset($_GET['id']) ? $_GET['id'] : "0";
$subid = isset($_GET['subid']) ? $_GET['subid'] : "0";

answered Aug 22, 2011 at 10:30

Prisoner

27.7k11 gold badges78 silver badges104 bronze badges

1 Comment

Prisoner Over a year ago

you have already marked this question as answered, which it is. If you really require it to be even shorter than it already is (which will just become a mess) then you should open a new question.

Andreas · Accepted Answer · 2011-08-22 10:37:21Z

1

foreach ($_GET as $key=>$value){
  if ($key === 'id' || $key === 'subid'){
    if(isset($value)) {
      $$key = $value;
    }else{
      $$key = '0';
    }
  }
}

edited Aug 22, 2011 at 10:37

answered Aug 22, 2011 at 10:31

Andreas

2,6682 gold badges22 silver badges33 bronze badges

4 Comments

Arjan Over a year ago

That's a great way to introduce unwanted variables and should be avoided as it is a potential security risk. You could make it more secure by checking the value of $key to a list of expected variables.

Andreas Over a year ago

I don't think so, I would like you to have a second look; I finished it now ... and by the way: 'extract' is definte much worse ...

Arjan Over a year ago

True, you were updating your post while I was typing my comment. This seems safe, although I would probably use in_array() to check $key.

Andreas Over a year ago

It really depends on the number of fields. If there are more fields, I would also prefer 'in_array()'.

Arjan · Accepted Answer · 2011-08-22 12:01:09Z

1

If you do not want several lines like:

$id = isset($_GET['id']) ? $_GET['id'] : 0;
$page = isset($_GET['page']) ? $_GET['page'] : 0;
$subid = isset($_GET['subid']) ? $_GET['subid'] : 0;
$feat = isset($_GET['feat']) ? $_GET['feat'] : 0;

Then this could be an alternative.

$keys = array('id', 'page', 'subid', 'feat');
foreach($keys as $key)
{
    $$key = isset($_GET[$key]) ? $_GET[$key] : 0;
}

Note that you loose the option to set different default values for the keys, or to treat different keys differently.

answered Aug 22, 2011 at 12:01

Arjan

9,8941 gold badge33 silver badges43 bronze badges

Comments

Jules · Accepted Answer · 2011-08-22 10:30:51Z

0

You could just declare your $id and $subid as 0 by default. And then write a simple if ( ... ) { }. Like this:

$id = 0;
$subid = 0;

if (isset($_GET['id']))
    $id = $_GET['id'];
if (isset($_GET['subid']))
    $subid = $_GET['subid'];

answered Aug 22, 2011 at 10:30

Jules

7,2236 gold badges28 silver badges51 bronze badges

Comments

pleasedontbelong · Accepted Answer · 2011-08-22 10:32:58Z

0

how about using extract()??

extract($_GET); // it will create all the vairables
// to set default values
$id = isset($id) ? $id : 0;
$subid = isset($subid) ? $subid : 0;

EDITED: a more elegant way

$id = $subid = 0;  // set default values
extract($_GET); // it will create all the variables and overwrite default values

answered Aug 22, 2011 at 10:32

pleasedontbelong

20.1k12 gold badges55 silver badges79 bronze badges

1 Comment

Arjan Over a year ago

You'll just introduce unchecked user input in your code. That's potentially dangerous and should be avoided. extract() can be useful, but not on user input.

Bob Vale · Accepted Answer · 2011-08-22 10:43:26Z

0

You could either use the ?: operators to remove the extra keyworks to make it a single line for each

$id= isset($_GET['id']) ? $_GET['id'] : 0;
$subid=isset($_GET['subid']) ? $_GET['subid'] : 0;

You could also create a function to do the work for you.

function getOrDefault($name, $default) {
  return isset($_GET[$name]) ? $_GET[$name] : $default);
}

This would allow you to create extra wrapper functions with defaults for various types.

function getInt($name) {
  return getOrDefault($name,0);
}

function getString($name) {
  return getOrDefault($name,"");
}

then your code becomes

$id = getInt('id');
$subid = get('subid');

answered Aug 22, 2011 at 10:43

Bob Vale

18.5k1 gold badge44 silver badges51 bronze badges

Collectives™ on Stack Overflow

Multiple If - else in php

10 Answers 10

1 Comment

2 Comments

1 Comment

1 Comment

1 Comment

4 Comments

Comments

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

10 Answers 10

1 Comment

2 Comments

1 Comment

1 Comment

1 Comment

4 Comments

Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related