How to improve array merge with for loop? [duplicate]

Question

I have a requirement where I am randomely creating numbers from an array for a game, I have a for loop which goes around for 10 times and generates random number and summing it up. I am not sure whether this is a good solution or not, can anyone suggest me some changes if required?

$target = array(1,rand(1,5)); 
for ($i = 0; $i < 10; $i++) 
{ 
   $target = array_merge( $target, array(rand($i,5),rand(1,$i)) ); 
} 
echo '<pre>';
print_r($target);

Relevant: Difference between array_push() and $array[] =

mickmackusa
– mickmackusa ♦

2022-11-02 06:01:17 +00:00
Commented Nov 2, 2022 at 6:01 — mickmackusa
– mickmackusa ♦, Commented Nov 2, 2022 at 6:01

Justinas · Accepted Answer · 2022-11-02 05:53:52Z

0

array_push is much faster than array_merge:

    $target = [1,rand(1,5)];

    for ($i = 0; $i < 10; $i++) 
    {
        array_push($target, rand($i, 5), rand(1, $i));
    }

If you have only 10 iterations, then you may not see difference. E.g. with 10000 iterations comparison:

array_merge - 0.451275s
array_push - 0.003301s

answered Nov 2, 2022 at 5:53

Justinas

43.9k5 gold badges72 silver badges108 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

How to improve array merge with for loop? [duplicate]

1 Answer 1

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Linked

Related