Generalization of a class constructor with interface (.Net Framework 4.8)

Question

Simplifying the question, I have these 2 functions

private void ReadFilesCommon(List<string> input)
{
    foreach (string entry in input)
    {
        new Class1(entry, entry.length);
    }
}

and

private void ReadFilesCommon2(List<string> input)
{
    foreach (string entry in input)
    {
        new Class2(entry);
    }
}

Is it possible to generalize these functions?

My main problem is the different inputs, but putting that aside, is it possible with interfaces?

Something like

private void ReadFilesCommon2(IClass Class)
{
    foreach ()
    {
        new Class(input1);
    }
}

You question is a little too generic/vauge. What does your foreach loop do with the class objects it instatiates? How much of the code is repated vs unique/depedant on the class it is working with (i.e. Class1 vs Class2)? — Peppermintology
– Peppermintology, Commented Dec 29, 2022 at 20:22
Class1 is completely different from Class2 and the foreach doesnt interact with the Class only with the input — Filipe
– Filipe, Commented Dec 29, 2022 at 20:36
you can try to define an interface that both Class1 and Class2 implement, and then pass an instance of that interface to the generalized function. — Kozydot
– Kozydot, Commented Dec 29, 2022 at 20:41
you're telling me that i should make the constructer as a function and use it with the interface. — Filipe
– Filipe, Commented Dec 29, 2022 at 20:51
How are the inputs provided, where do they come from? Your question is still too vague. — Peppermintology
– Peppermintology, Commented Dec 29, 2022 at 20:55

Alexei Levenkov · Accepted Answer · 2022-12-29 21:44:20Z

1

Factory method/interface seem to be what you are looking for:

private void ReadFiles<T>(List<string> input, Func<string, T> creator)
{
    foreach (string entry in input)
    {
        var item = creator(entry);
    }
}

// and replace your functions with:
ReadFiles(input, s => new Class1(s)); // ReadFilesCommon
ReadFiles(input, s => new Class2(s, s.Length)); // ReadFilesCommon1

answered Dec 29, 2022 at 21:44

Alexei Levenkov

101k15 gold badges138 silver badges189 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Generalization of a class constructor with interface (.Net Framework 4.8)

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related