Angular 14 if statement refactor

Question

I have the following code:

public selectionChange(value: any): void {
let commodityDescription = '';
if (!value) { 
  this.loadForm.patchValue({
    commodityDescription: commodityDescription
  });
  return; 
}

if (this.initialFormValue.commodityId === value.commodity.commodityId) {
  commodityDescription = this.initialFormValue.commodityDescription;
} else {
  commodityDescription = value.commodity.description;
}

this.loadForm.patchValue({
  commodityDescription: commodityDescription
});
}

and I don't like having the patchValue statement in there twice. I'm trying to find a way to refactor the method so that it's only called once. Been playing with a switch statement but can't get it to work.

depperm · Accepted Answer · 2023-01-17 15:21:40Z

1

Change the first if to cover the others

public selectionChange(value: any): void {
    let commodityDescription = '';
    if (value) {  
      if (this.initialFormValue.commodityId === value.commodity.commodityId) {
        commodityDescription = this.initialFormValue.commodityDescription;
      } else {
        commodityDescription = value.commodity.description;
      }
    }

    this.loadForm.patchValue({
      commodityDescription: commodityDescription
    });
}

answered Jan 17, 2023 at 15:21

depperm

10.8k4 gold badges46 silver badges68 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Krenom · Accepted Answer · 2023-01-17 15:23:14Z

1

public selectionChange(value: any): void {
    let commodityDescription = '';
    if (value) {
        commodityDescription = this.initialFormValue.commodityId === value.commodity.commodityId
            ? this.initialFormValue.commodityDescription
            : value.commodity.description;
    }

    this.loadForm.patchValue({
        commodityDescription: commodityDescription
    });
}

answered Jan 17, 2023 at 15:23

Krenom

2,1282 gold badges14 silver badges23 bronze badges

Collectives™ on Stack Overflow

Angular 14 if statement refactor

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related