Java: InputStream.read doesn't wait for input?

Question

G'day, I'm working on a proxy, but one of the socket's inputstream is being weird:

while(true) {
        try {
            while ((BytesRead = inputstream.read(Line)) != -1) {
                OtherSocket.Write(Line, BytesRead);
            }
        } catch (IOException e) {
            e.printStackTrace();
        }
    }

I have pretty much the same thing for the OtherSocket, but on this one, it keeps repeating as if the server keeps sending data, I'm guessing that inputstream.read(Line) isn't waiting for input but returns -1. Is there any reason why inputstream.read(Line) wouldn't wait for input as it's meant to?

If this code is Java it uses an unidiomatic writing style, which makes it hard to understand the code. — migu
– migu, Commented Oct 11, 2011 at 11:40

Jon Skeet · Accepted Answer · 2011-10-11 11:40:15Z

2

I believe InputStream.read will keep returning -1 after the socket has been closed by the other end.

Why would you want to keep trying to read from a stream which has already returned -1 from read? That seems to be the bug to me. If you want to keep the while(true) loop you should put a break; statement after the inner while loop, so that if you've just managed to reach the end of the stream normally with no problems, you can just exit the outer loop.

I strongly suspect that trying to read from a stream after it's already failed is a bad idea too, by the way.

(I'd also suggest that you start following more conventional Java naming - it's very odd to see PascalCase variable names. It's also odd to see a method called Write - that's certainly not something on java.io.OutputStream...)

answered Oct 11, 2011 at 11:40

Jon Skeet

1.5m893 gold badges9.3k silver badges9.3k bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Thom Over a year ago

In regards to Jon's answer, you're not showing us which implementation of InputStream you're using. Each one gets to define EOF conditions. We need to know the concrete implementation to be of more help.

Collectives™ on Stack Overflow

Java: InputStream.read doesn't wait for input?

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related