Pointer with a pointer constructor

Question

In C++, how can I achieve the following:

// player.h
#ifndef PLAYER_H
#define PLAYER_H
class Player {
    public:
        Player(Cake* cake);
}
#endif

// player.cpp
#include "cake.h"
#include "player.h"
Player::Player(Cake* cake) { }

// cake.h
#ifndef CAKE_H
#define CAKE_H
class Cake {
    public:
        Cake( );
}
#endif

// cake.cpp
#include "cake.h"
Cake::Cake() { }

// main.cpp
#include "player.h"
#include "cake.h"
int main() {
    Cake* cake();
    Player* player(cake); // This does not work

    return 0;
}

In other words, Have a Player pointer that takes a Cake pointer in it's constructor.

However, when I try compiling the application with g++ i get the following error: error: cannot convert ‘Cake* (*)()’ to ‘Player*’ in initialization.

It probably makes sense, but I'd like to know why I can't have a pointer that takes a pointer (in the constructor).

What's wrong with automatic variables? Cake cake; Player player(cake); is much easier and better. — sbi
– sbi, Commented Oct 28, 2011 at 13:54
This is just a dummy application I made, the "real" application looks a bit different. I had some problems with inheritance when I did not use pointers (e.g virtual functions in the parent class seemed to get called every time when the purpose was to call a child class' inherited function. — whirlwin
– whirlwin, Commented Oct 28, 2011 at 22:57
Oh my. That sounds bad. You might want to get yourself a good C++ book. — sbi
– sbi, Commented Oct 29, 2011 at 10:06

Linus Kleen · Accepted Answer · 2011-10-28 11:17:42Z

2

This looks like a mistaken local initialization.

Cake* cake();
Player* player(cake);

needs to be rewritten to

Cake* cake = new Cake();
Player* player = new Player(cake);

answered Oct 28, 2011 at 11:17

Linus Kleen

34.8k10 gold badges97 silver badges100 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

iammilind · Accepted Answer · 2011-10-28 11:21:06Z

2

Cake* cake();

Here cake is not a variable as you might assume. Compiler looks as if cake() is a forward declaration which returns Cake* and takes no argument.

It can be,

Cake cake;
Player *player = new Player(&cake);

answered Oct 28, 2011 at 11:21

iammilind

70.5k39 gold badges188 silver badges364 bronze badges

Comments

Luchian Grigore · Accepted Answer · 2011-10-28 11:16:18Z

1

This is the proper C++ syntax:

Cake* cake = new Cake();
Player* player = new Player(cake);

answered Oct 28, 2011 at 11:16

Luchian Grigore

260k68 gold badges465 silver badges634 bronze badges

Comments

codencandy · Accepted Answer · 2011-10-28 11:18:46Z

1

Cake is an unknown type in player.h . Use a forward declaration:

// player.h

class Cake;

class Player
{
  private:
    Cake* m_cake;
  public:
    Player( Cake* c ) : m_cake(c) {}
};

answered Oct 28, 2011 at 11:18

codencandy

1,7311 gold badge10 silver badges20 bronze badges

Collectives™ on Stack Overflow

Pointer with a pointer constructor

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related