Multiple dynamic selectors in jQuery using variables

Question

Using a single dynamic selector I have no problems:

var answer_id = <?php echo $answer_id; ?>;

$('#a_flag_' + answer_id).click(function(e) {
        e.preventDefault();

         //Ajax etc...

But if I add several dynamic selectors they do not work (ie, no errors on Firebug console, but also no action when clicked):

var answer_id = <?php echo $answer_id; ?>;

$('#a_flag_' + answer_id,'#a_comments_link_' + answer_id,'#a_best_answer_' + answer_id).click(function(e) {
        e.preventDefault();

         //Ajax etc...

Any ideas what I am doing wrong?

Pointy · Accepted Answer · 2011-10-30 22:16:42Z

5

You need the commas inside the quoted constant strings.

$('#a_flag_' + answer_id + ', #a_comments_link_' + answer_id + ',  #a_best_answer_' + answer_id).click(// ///

What you want to end up with is a string that looks like

"selector, selector, selector, ..."

so you need to concatenate a bunch of strings with commas.

Alternatively, you could build up your separate selectors in an array of strings and then ".join()" them with a comma separator (the parameter to ".join()").

answered Oct 30, 2011 at 22:16

Pointy

415k62 gold badges600 silver badges631 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

lc2817 · Accepted Answer · 2011-10-30 22:17:52Z

1

You should put the coma inside the string not outside and you have forgotten the plus.

$('#a_flag_' + answer_id + ', #a_comments_link_' + answer_id +',#a_best_answer_' + answer_id)

answered Oct 30, 2011 at 22:17

lc2817

3,76219 silver badges40 bronze badges

Comments

user166390 · Accepted Answer · 2011-10-30 22:19:58Z

1

When it starts to look too complicated, it likely is. FWIW:

var selectors = [
  '#a_flag_' + answer_id,
  '#a_comments_link_' + answer_id
  // etc.
]
$(selectors.join(", ")).click(...)

Happy coding.

answered Oct 30, 2011 at 22:19

user166390

Collectives™ on Stack Overflow

Multiple dynamic selectors in jQuery using variables

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related