C# Refactoring Code

Question

Currently I have code that looks like this

Status("Start Step 1");
result = Step1();
Status("End Step 1", result);

Status("Start Step 2");
result = Step2();
Status("End Step 2", result);

Status("Start Step 3");
result = Step3();
Status("End Step 3", result);

Would it be possible to somehow refactor this code and get rid of the status lines. -- however it is very important to update the status at the start and end of each step.

I thought about moving the status lines into the Step1,2,3 calls but that just clutters up the methods.

Create a function that accepts a lambda (containing Step1, 2, 3...). Call that functon with appropriate lambda; have it increment a local step number, and print "Start <step>", do the lambda, print "End Step". — Ira Baxter
– Ira Baxter, Commented Dec 6, 2011 at 4:30

jason · Accepted Answer · 2011-12-06 04:39:49Z

5

public void ExecuteAndLog(Func<T> func, string startMessage, string endMessage) {
    Status(startMessage);
    var result = func;
    Status(endMessage, result);
}

with the obvious invocations

You can refine as needed. For example, building on the previous:

public void ExecuteAndLog(Func<T> func, string message) {
    ExecuteAndLog(func, "Start " + message, "End " + message);
}

making the invocations slightly simpler and even

public void ExecuteAndLog(Func<T> func, int stepNumber) {
    ExecuteAndLog(func, String.Format("Step {0}", stepNumber));
}

building on the previous. So now you can say

ExecuteAndLog(Step1, 1);
ExecuteAndLog(Step2, 2);
ExecuteAndLog(Step3, 3);

edited Dec 6, 2011 at 4:39

answered Dec 6, 2011 at 4:33

jason

243k35 gold badges436 silver badges532 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

John Saunders Over a year ago

+1, but recommend placing func last. The call would then be ExecuteAndLog("Start step 1", "End step 1", ()=>Step1())

kelloti · Accepted Answer · 2011-12-06 04:38:00Z

1

Slight improvement over @Jason

public object ExecuteAndLog(Func<T> func, int number) {
    Status(string.Format("Start Step {0}", number));
    var result = func;
    Status(string.Format("End Step {0}", number), result);
    return result;
}

// and used like:

var result = ExecuteAndLog(Step1, 1);
result = ExecuteAndLog(Step2, 2);
result = ExecuteAndLog(Step3, 3);

answered Dec 6, 2011 at 4:38

kelloti

8,9596 gold badges52 silver badges86 bronze badges

Comments

jasonp · Accepted Answer · 2011-12-06 04:38:41Z

1

Maybe something like this:

public void RunStep<T>(string stepName, Func<T> stepFunc)
    {
        Status("Start Step " + stepName);
        var result = stepFunc();
        Status("End Step " + stepName, result);
    }

Which would be called like:

RunStep("1", Step1);
RunStep("2", Step2);
RunStep("3", Step3);

answered Dec 6, 2011 at 4:38

jasonp

4104 silver badges6 bronze badges

Comments

Arnon Rotem-Gal-Oz · Accepted Answer · 2011-12-06 04:59:30Z

0

if they all return the same result type you can do that like

    Runner(Step1, Step2, Step3);


    public void Runner<T>(params Func<T>[] stepList)
    {
        foreach (var act in stepList)
        {
            Status(act.Method.Name + "Started");
            var result=act.Invoke();
            Status(act.Method.Name + "Ended", result);  
        }


    }

answered Dec 6, 2011 at 4:59

Arnon Rotem-Gal-Oz

26k3 gold badges51 silver badges70 bronze badges

Comments

Nokib Bin Faruk · Accepted Answer · 2013-06-06 03:55:31Z

0

You can use Spring.Net logger to avoid calling Status again and again.

Thanks.

answered Jun 6, 2013 at 3:55

Nokib Bin Faruk

474 bronze badges

Collectives™ on Stack Overflow

C# Refactoring Code

5 Answers 5

1 Comment

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related