is it safe to use javascript module pattern?

Question

I've been using javascript module pattern for while.

I showed an example of a module pattern to one of my coworkers. He said that the following code can make a memory leak.

var test = (function(){

   var events = {
      // my functions go here
   }

   return {
     // return something
   }

}());

he said that since events variable is an object and i'm not setting null for it, it can cause a memory leak even if I set null for test later.

As far as I know, the above code snippet is okay because I'm not passing events around.

I need advices!

bbg · Accepted Answer · 2011-12-18 20:29:41Z

3

I think your code is fine. Memory leaks in closures happen when you have a reference to a DOM element, because of the circular reference (foo holds on to element, and element holds on to foo, so they can never be garbage collected):

function foo(element, a, b) {
    element.onlick = function(a, b) { /* uses a and b */ };
}

My source for this belief is here

But others might know of another problem ...

edited Dec 18, 2011 at 20:29

answered Dec 18, 2011 at 7:03

bbg

3,1203 gold badges20 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ed Heal · Accepted Answer · 2011-12-18 07:10:51Z

0

@moon - Why worry too much? How often is that code getting executuded between sittings? How many bytes are going to get lost? Then you have to consider the various browsers that will interperet and run your Javascript.

In short - concentrate your efforts elsewhere - then you get better rewards.

answered Dec 18, 2011 at 7:10

Ed Heal

60.3k18 gold badges91 silver badges137 bronze badges

8 Comments

Moon Over a year ago

// um...I put that code sample not because I'm using that code. That's just an example as I mentioned on my post.

Ed Heal Over a year ago

@moon - I just think that your efforts will be better served elsewhere. (BTW - Name from Enid Btyton - Folk of the far away tree)

Moon Over a year ago

// i appreciate and understand your intention here, but a memory leak is not something that I want to skip; concentrating my efforts elsewhere by leaving a known problem is a problem in my humble opinion

Ed Heal Over a year ago

@moon - How big is that memory leak? A few bytes? Perhaps better to look at the server end and dish out some better cavar?

Moon Over a year ago

// as I mentioned...this is..just a sample snippet code. Let's assume that the above code causes a memory leak. If I keep using that on my all projects, that would be a problem. Again, I understand what you mean...but I'm a learner here.

|

Collectives™ on Stack Overflow

is it safe to use javascript module pattern?

2 Answers 2

Comments

8 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

8 Comments

Your Answer

Sign up or log in

Post as a guest

Related