Parse error: syntax error, unexpected T_IF

Question

$query = "SELECT a.*, cc.name AS category, dd.ezcity AS proploc, ee.name AS statename, ff.name AS cnname, ss.dealer_name AS propseller, u.name AS editor"

. "\n FROM #__ezrealty AS a"

. "\n LEFT JOIN #__ezrealty_catg AS cc ON cc.id = a.cid"

. "\n LEFT JOIN #__ezrealty_locality AS dd ON dd.id = a.locid"

. "\n LEFT JOIN #__ezrealty_state AS ee ON ee.id = a.stid"

. "\n LEFT JOIN #__ezrealty_country AS ff ON ff.id = a.cnid"

. "\n LEFT JOIN #__ezrealty_profile AS ss ON ss.mid = a.owner"

. "\n LEFT JOIN #__users AS u ON u.id = a.checked_out"

. ( count( $where ) ? "\n WHERE " . implode( ' AND ', $where ) : "")

. if ( isset ($_POST['idSearch']) ) 

    . { " WHERE a.id = " . $_POST['idSearch']  ; }

. "\n ORDER BY ". $order

. "\n LIMIT $pageNav->limitstart, $pageNav->limit"

;

i don get the wrong syntax here :( ,, and it keep return the same error unexpected T_IF

. (!empty($_POST['idSearch']) ? " WHERE a.id = " . $_POST['idSearch'] : "\n ORDER BY ". $order ."\n LIMIT $pageNav->limitstart, $pageNav->limit"); This is the right solution to search in the all pages not only the displayed one — omnia Mm
– omnia Mm, Commented Dec 22, 2011 at 8:38

Alex van den Hoogen · Accepted Answer · 2011-12-21 15:55:49Z

3

Remove the . (point) before the if-statement. Because the if-statement itself isn't a string you can't just concatenate it.

answered Dec 21, 2011 at 15:55

Alex van den Hoogen

7481 gold badge7 silver badges22 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Alex Howansky · Accepted Answer · 2011-12-21 15:57:31Z

2

Don't do this:

. if (condition) { value_if_true; }

Instead do this:

. (condition ? value_if_true : value_if_false)

answered Dec 21, 2011 at 15:57

Alex Howansky

54k8 gold badges85 silver badges102 bronze badges

Comments

lonesomeday · Accepted Answer · 2011-12-21 15:58:17Z

1

if can only ever be a statement: you are using it as an expression. It doesn't return anything, and it cannot be used within another statement.

You can, however, use the ternary operator to do exactly this:

. ( isset ($_POST['idSearch']) ?  " WHERE a.id = " . $_POST['idSearch'] : '')

This says "if $_POST['idSearch'] is set, add that string, otherwise, add the empty string.

Note that you should really look at your code, because there is a glaring SQL injection in just the code that I've posted above. Anyone could execute arbitrary code on your database. Make sure to sanitise your input and, preferably, adopt prepared statements and parameterised queries to make your code more secure.

answered Dec 21, 2011 at 15:58

lonesomeday

239k54 gold badges330 silver badges329 bronze badges

3 Comments

omnia Mm Over a year ago

SQL=SELECT a.*, cc.name AS category, dd.ezcity AS proploc, ee.name AS statename, ff.name AS cnname, ss.dealer_name AS propseller, u.name AS editor FROM jos_ezrealty AS a LEFT JOIN jos_ezrealty_catg AS cc ON cc.id = a.cid LEFT JOIN jos_ezrealty_locality AS dd ON dd.id = a.locid LEFT JOIN jos_ezrealty_state AS ee ON ee.id = a.stid LEFT JOIN jos_ezrealty_country AS ff ON ff.id = a.cnid LEFT JOIN jos_ezrealty_profile AS ss ON ss.mid = a.owner LEFT JOIN jos_users AS u ON u.id = a.checked_out WHERE a.id = ORDER BY a.id DESC LIMIT 0, 5

lonesomeday Over a year ago

I'm not quite sure how I'm supposed to debug that, but my guess is that $_POST['idSearch'] is set but empty. I could be wrong. You aren't exactly giving a lot of details...

omnia Mm Over a year ago

it is empty ,, it is suppose if it is empty do nothing and retrieve the all data not the specific one ,, i think i will get the post by hyper link and query string :) , thnx all

Explosion Pills · Accepted Answer · 2011-12-21 15:57:47Z

0

I believe you want to turn this into an evil ternary operator:

. (count ...)
. (isset($_POST['idSearch']) ? ' WHERE a.id = ' . $_POST['idSearch'] : '')
. "\n ORDER BY" ...

answered Dec 21, 2011 at 15:57

Explosion Pills

192k56 gold badges341 silver badges417 bronze badges

2 Comments

gen_Eric Over a year ago

Why is the ternary operator evil?

Explosion Pills Over a year ago

@Rocket I don't think it is, but there are plenty of developers that do. One example of a problem is that you can't add operations to the condition after the fact.

Collectives™ on Stack Overflow

Parse error: syntax error, unexpected T_IF

4 Answers 4

Comments

Comments

3 Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

3 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related