Comparing two fields in a form in Javascript - Not working

Question

Can anyone tell me what I am doing wrong? my comparePasswords() is not working...

        <script>

            function comparePasswords()
            {
                if (post-form.password.value != post-form.password2.value)
                {
                    $('passwordShow').innerHTML = '';
                }
                else
                {
                    $('passwordShow').innerHTML = 'Passwords do not match';
                }
            }
        </script>


<form id="post-form" action="signup.php" method="post" >

<input type="password" id="password" name="password" onkeyup="testPassword(this.value);" maxlength="50" size="25" tabindex="102" value="">

<input type="password" id="password2" name="password2" onkeyup="comparePasswords();" maxlength="50" size="25" tabindex="104" value="">

</form>

alex · Accepted Answer · 2009-05-27 00:45:06Z

1

you need to use

document.getElementById('password').value

and

document.getElementById('password2').value

Also, your logic is wrong. The first conditional block will fire if the passwords do not match.

EDIT

seems you are using jQuery, so simply use

$('#password').val()

to get the field's value.

You should also set the innerHTML using jQuery (may as well) with the html() method

answered May 27, 2009 at 0:45

alex

492k205 gold badges890 silver badges992 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

nickf · Accepted Answer · 2009-05-27 00:45:18Z

1

The problem is with how you're accessing the form object.

post-form.password

To the javascript engine, this is the same as this:

post - (form.password)

Also, you'd have to give your form a name attribute (not just an id) to access it that way. If you wanted to access it by name, you'd use something like this:

document['post-form'].password

Or by id:

document.getElementById("post-form");

answered May 27, 2009 at 0:45

nickf

548k199 gold badges660 silver badges727 bronze badges

2 Comments

alex Over a year ago

15 chars? heh e

nickf Over a year ago

:) !

Evan Meagher · Accepted Answer · 2009-05-27 00:44:17Z

0

The test in your if is backwards. The first branch is testing if the two passwords are NOT equal to each other.

answered May 27, 2009 at 0:44

Evan Meagher

4,56523 silver badges18 bronze badges

Collectives™ on Stack Overflow

Comparing two fields in a form in Javascript - Not working

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related