How to define an array of strings of characters in header file?

Question

I have many different 3 axis sensors I am writing test code for. In the C files for each of them, I have the same char string defined:

char axis[3][8] = {"X", "Y", "Z"}

which I use when I "for" loop results to print the axis that is failing like this:

DEVICETEST_LOG("%s Failed %s axis for Min range\n",device_name[DUT], axis[i]);

I was thinking to save some space I could define a character string array in a header file to use all over the place.

I have tried a number of things, but I can't seem to get an array of strings defined in my header file that I can iterate through to pass a compile.

nbro · Accepted Answer · 2017-11-22 13:12:50Z

45

If you must put it in a header file, use extern or static:

// option 1
// .h
extern char axis[3][8];

// .c
char axis[3][8] = { "X", "Y", "Z" };

// option 2
// .h
static char axis[3][8] = { "X", "Y", "Z" };

Extern tells the linker that there is a global variable named axis defined in one of our implementation files (i.e. in one .c file), and I need to reference that here.

static, on the other hand, tells the compiler the opposite: I need to be able to see and use this variable, but don't export it to the linker, so it can't be referenced by extern or cause naming conflicts.

edited Nov 22, 2017 at 13:12

nbro

16.1k34 gold badges122 silver badges219 bronze badges

answered Feb 8, 2012 at 16:01

Richard J. Ross III

55.7k25 gold badges139 silver badges205 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Victor Over a year ago

Note that, when using static and compiling with -Wunused, if you do not use that array in that compilation unit, you''get a warning about it.

Jason · Accepted Answer · 2012-02-08 17:09:26Z

28

In order to avoid linker errors, you have to declare your array as extern in a header file, and then define the array once in one of your code modules.

So for instance:

//myheader.h
extern const char* axis[3];

then in another code module somewhere:

//myfile.c
const char* axis[3] = { "X", "Y", "Z" };

edited Feb 8, 2012 at 17:09

answered Feb 8, 2012 at 16:00

Jason

32.7k8 gold badges63 silver badges81 bronze badges

5 Comments

user1054210 Over a year ago

ah that makes sense but seems bassackwards... So the header file I include everywhere points all the other C files to the "myfile.c" local definition.

user1054210 Over a year ago

So even though I have included the header file in the other c files I am getting a compile error "undefined refrence". So in myheader.h I have >>extern char* AXIS[3][8]; and in myfile.c I have >>char* AXIS[3][8] = {{"X"}, {"Y"}, {"Z"}}; and I am including the myheader.h in the otherfile.c. I also tried a few other tricks but they are not synching up.

Jason Over a year ago

Something else is wrong then because this does work ... what happens if you take the macro out of the equation and simply try to access the array in another code module that includes the header file? Secondly, it should only be const char* AXIS[3] = { "X", "Y", "Z" }; since these are string literals ... where are you getting the 8 from?

user1054210 Over a year ago

I have the 8 there because I get a compile error otherwise. The compiler claims "error: format'%s' expects 'char *' but argument 5 has type 'int'" on the print line basically stateing the assignment of axis[i] to %s is wrong because it is an int even though it is defined as a char.

user1054210 Over a year ago

By the way ...DUHH that is so stupid of me...why have it in a header file. Just make a global in the high level test file that calls all of the low level files that is extern defined in the low level files. I did not have enough coffee yet when I was thinking this through.

Robᵩ · Accepted Answer · 2012-02-08 16:01:55Z

8

Add this to your header:

extern char *axis[];

Add this to one source file in your project:

char *axis[] = { "X", "Y", "Z", "Time", "Space", "The Scary Door" };

answered Feb 8, 2012 at 16:01

Robᵩ

170k20 gold badges251 silver badges323 bronze badges

1 Comment

b3h3m0th Over a year ago

Well done! I use this when I need to create a menu' with indefinite number of elements. It's perfect because at compile time the compiler sets up the array length exactly, moreover the code seems to be much more readable.

Sergey Kalinichenko · Accepted Answer · 2012-02-08 16:01:46Z

3

Put this in your header file

extern char axis[3][8];

and keep this in a C file:

char axis[3][8] = {"X", "Y", "Z"};

answered Feb 8, 2012 at 16:01

Sergey Kalinichenko

729k85 gold badges1.2k silver badges1.6k bronze badges

Comments

Throwback1986 · Accepted Answer · 2012-02-08 16:17:06Z

0

Michael Barr (Netrino) advises against the declaration of storage in a header file. Likewise, the Netrino embedded system coding standard does not condone the use of extern'ed storage in headers.

I generally agree with these principles, and I've found it to be a good idea to extern storage into the C files that need it, and only those.

answered Feb 8, 2012 at 16:17

Throwback1986

5,9951 gold badge35 silver badges23 bronze badges

Collectives™ on Stack Overflow

How to define an array of strings of characters in header file?

5 Answers 5

1 Comment

5 Comments

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

5 Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related