How add only not empty/null restriction to query

Question

Do you have an idea how to write the following code nicer/shorter :) I need to check if the field form form is not empty and then add criterion to the query, thanks :)

AbstractCriterion restrictions = null; 

if (model.DateFrom != null) 
  AddRestriction(ref restrictions, 
   Restrictions.Ge(Projections.Property<Invoice>(x => x.DateIn), model.DateForm)); 

if (model.DateTo != null) 
  AddRestriction(ref restrictions, 
    Restrictions.Le(Projections.Property<Invoice>(x => x.DateIn), model.DateTo)); 

if (!string.IsNullOrEmpty(model.Prop1)) 
   AddRestriction(ref restrictions, 
     Restrictions.Eq(Projections.Property<Invoice>(x => x.Prop1), model.Prop1)); 

// ... many more conditions :) 

return m_session.QueryOver<Invoice>().Where(restrictions).List();

Jamie Ide · Accepted Answer · 2012-02-13 16:58:39Z

1

You don't need the ref keyword for starters. I think this is nicer without sacrificing readability:

var query = session.QueryOver<Invoice>();

Action<object, ICriterion> addIfNonNull = (o, c) =>
                                            {
                                                if (o != null)
                                                {
                                                    query.And(c);
                                                }
                                            };

addIfNonNull(model.Prop1, Restrictions.Eq(Projections.Property<Invoice>(x => x.Prop1), model.Prop1));

etc.

edited Feb 13, 2012 at 16:58

answered Feb 12, 2012 at 20:51

Jamie Ide

49.4k18 gold badges85 silver badges118 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

How add only not empty/null restriction to query

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related