Moving element in array

Question

I'm not sure why the code below is not working, I'm trying to find the value of NaN in the array and then move NaN to the first element in the array (element 0) and swap the existing element 0 with wherever the NaN was. Please can you check my code out? Maybe you guys/girls can see something I can't?

Thanks in advance!

#define NaN (float)(1e308*10*0)


void movenan(float array[], int size)
{
int w;
float hold;
float move;

for(w = 0; w < SIZE - 1; w++)
{
    if(array[w] == NaN)
    {
        hold = array[w];
        array[w] = array[0];
        array[0] = hold;
    }
}

}

I think you can't test for NaN this way. See this post: stackoverflow.com/questions/570669/… — dbrank0
– dbrank0, Commented Feb 24, 2012 at 8:41
I assume you want to loop over the array until w < size rather than w < SIZE - 1, not? < means "smaller than" so the -1 isn't needed (unless you want to skip the last element in the array). — user1203803
– user1203803, Commented Feb 24, 2012 at 8:49

Community · Accepted Answer · 2017-05-23 10:34:50Z

6

Your NaN check is wrong: NaNs don't compare equal to anything, including themselves.

Use isnan() to check whether the value is NaN.

If isnan() is not available, the canonical way to check whether f is NaN is as follows: f != f. This evaluates to true iff f is NaN.

There is a lot more information here: Checking if a double (or float) is NaN in C++ (the question is about C++, but there is a lot of information about C as well.)

Finally, the terminal condition of your for loop looks suspect. Did you mean < SIZE or <= SIZE-1?

edited May 23, 2017 at 10:34

CommunityBot

11 silver badge

answered Feb 24, 2012 at 8:41

NPE

503k114 gold badges970 silver badges1k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

jkerian · Accepted Answer · 2012-02-24 08:42:58Z

2

I suspect the problem is your nan comparison. NaNs are not that consistant.

You should be using the isnan() function, or one of it's variants. If you don't want to use isnan for some silly reason, the easiest way to check for a nan is if(array[w] != array[w]). With a real NAN, that should work, presuming your optimizer doesn't take that out.

You're also off by one on that loop (should be w < size, SIZE is probably something else, and you don't want to go until size-1)

answered Feb 24, 2012 at 8:42

jkerian

17.2k3 gold badges49 silver badges59 bronze badges

1 Comment

user1203803 Over a year ago

If the optimizer eliminates != on floats, you really need a better compiler.

Gilles 'SO- stop being evil' · Accepted Answer · 2012-02-24 10:07:40Z

0

If you trying to parse the whole array then the condition should be w<size otherwise it parses only till the second last element.

edited Feb 24, 2012 at 10:07

Gilles 'SO- stop being evil'

109k38 gold badges217 silver badges263 bronze badges

answered Feb 24, 2012 at 8:41

codious

3,5216 gold badges28 silver badges46 bronze badges

2 Comments

codious Over a year ago

I cant see my whole text here for some reason. Your loop condition should be w<size

Gilles 'SO- stop being evil' Over a year ago

The < character starts some HTML formatting. You need to use code markup (see the edit). Click the ? button on the right-hand side of the button bar in the editor for more information about markup.

Collectives™ on Stack Overflow

Moving element in array

3 Answers 3

Comments

1 Comment

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related