jquery function scope

Question

I'm not understanding function scope here. I have a button when clicked shows a dialog with a textarea. Inside that textarea I populate it with a url that someone can then copy for their camera setup.

<button id="axis-details" onclick="apikey('<?php echo $result_cameras[$i]["camera_hash"]; ?>');">API Key</button>

function apikey(camerahash)
{
   var $key = "http://myhost.com/notify.php/" +camerahash;
   return $key;
}

$(document).ready(function() {
   var $dialog = $('<div></div>');
$dialog.append('Please copy this key for camera setup: ')
       .append('<p><textarea id=\"textbox\">'+apikey(camerahash)+'</textarea></p>') //ERROR here that camerahash is not defined
       .append('<p>For more information see: <a href=\"http://www.myhost.com/forum/2-quickstart-docs\">setup</a></p>');
$dialog.dialog({
    autoOpen: false,
    title: 'API Key'
});

$('#axis-details').click(function(e) {
    e.preventDefault();
    $dialog.dialog('open');
});
});

Function apikey(camerahash) does return the value I expect. I get an error indicated above that camerahash is not defined. What am I doing wrong?

In your code you never initialize camerahash did you forget something? — Michael Laffargue
– Michael Laffargue, Commented Mar 8, 2012 at 16:20
the error indicating that camerahash is not defined is because camerahash is not defined... not sure how much clearer that can get — jbabey
– jbabey, Commented Mar 8, 2012 at 16:25

Lazarus · Accepted Answer · 2012-03-08 16:20:47Z

2

I think this is what you actually want:

<button id="axis-details">API Key</button>

function apikey(camerahash)
{
   var $key = "http://myhost.com/notify.php/" +camerahash;
   return $key;
}

$(document).ready(function() {
   var $dialog = $('<div></div>');
$dialog.append('Please copy this key for camera setup: ')
       .append('<p><textarea id=\"textbox\">'+apikey(<?php echo $result_cameras[$i]["camera_hash"]; ?>)+'</textarea></p>') //ERROR here that camerahash is not defined
       .append('<p>For more information see: <a href=\"http://www.myhost.com/forum/2-quickstart-docs\">setup</a></p>');
$dialog.dialog({
    autoOpen: false,
    title: 'API Key'
});

$('#axis-details').click(function(e) {
    e.preventDefault();
    $dialog.dialog('open');
});
});

answered Mar 8, 2012 at 16:20

Lazarus

43.2k4 gold badges47 silver badges54 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Tom Over a year ago

I wish it was that simple. The php code goes through a loop to print out the camera_hash. Thanks for the help, I guess I've got a bigger problem.

Andrew · Accepted Answer · 2012-03-08 16:20:30Z

2

It is only defined in your apikey function, you need to also pass it in from your jquery method,

 .append('<p><textarea id=\"textbox\">'+apikey('<?php echo $result_cameras[$i]["camera_hash"]; ?>')+'</textarea></p>')

Or even easier, modify your function to not need the input,

function apikey()
{
   var $key = "http://myhost.com/notify.php/" +'<?php echo $result_cameras[$i]["camera_hash"]; ?>';
   return $key;
}

answered Mar 8, 2012 at 16:20

Andrew

13.9k14 gold badges70 silver badges85 bronze badges

1 Comment

Reinstate Monica Cellio Over a year ago

Or even easier still, don't use a function!

Collectives™ on Stack Overflow

jquery function scope

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related