Injecting specific implementations using Unity

Question

I have 2 implementations of an interface where I need to inject the first implementation into one service and the second implementation into another. Each service is also injected with other dependencies that do not have multiple implementations.

So far, I have something like this:

public FirstService(IDataRepository dr, IOtherRepository or)
{
    this.DataRepository = dr;
    this.OtherRepository = or;
}

public SecondService(IDataRepository dr, IAnotherRepository ar)
{
    this.DataRepository = dr;
    this.OtherRepository = ar;
}

Then in my bootstrapper I have:

container.RegisterType<IDataRepository, FirstDataRepository>("First");
container.RegisterType<IDataRepository, SecondDataRepository>("Second");
container.RegisterType<IOtherRepository ,OtherRepositor>();
container.RegisterType<IAnotherRepository ,AnotherRepository>();

container.RegisterType<IFirstService, FirstService>(new InjectionConstructor(new ResolvedParameter<IDataRepository>("First")));
container.RegisterType<ISecondService, SecondService>(new InjectionConstructor(new ResolvedParameter<IDataRepository>("Second")));

When I run my application I get the error: "FirstService does not have a constructor that takes the parameters (IDataRepository)."

Do I need to also specify the instance of IOtherRepository that needs to be injected now that I am specifically specifying the instance of IDataRepository that should be injected? Or am I doing something else wrong?

My actual constructor takes 6 arguments and it would be a pain to have to manually inject each of them just because one of them has multiple implementations.

Sebastian Weber · Accepted Answer · 2012-03-09 19:40:17Z

3

You don't have to specify the values for the other parameters but you must specify their Type so that Unity can identify which constructor to use.

The registration for IFirstService would then look like this

container.RegisterType<IFirstService, FirstService>(new InjectionConstructor(new ResolvedParameter<IDataRepository>("First"), typeof(IOtherRepository)));

The TecX project on codeplex includes the ClozeInjectionConstructor that deals with situations like these where you only want to specify a single parameter. See the sourcecode in the TecX.Unity project.

Btw: 6 parameters for a constructor are a code smell for the constructor over injection anti-pattern.

edited Mar 9, 2012 at 19:40

answered Mar 9, 2012 at 19:34

Sebastian Weber

6,7182 gold badges32 silver badges51 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Nachiket Mehta · Accepted Answer · 2012-03-09 19:41:56Z

0

container.RegisterType<IFirstService, FirstService>(new InjectionConstructor(new ResolvedParameter<IDataRepository>("First"), new ResolvedParameter<IOtherRepository>()));
container.RegisterType<ISecondService, SecondService>(new InjectionConstructor(new ResolvedParameter<IDataRepository>("Second"), new ResolvedParameter<IAnotherRepository>()));

You need to resolve the second constructor parameter.

answered Mar 9, 2012 at 19:41

Nachiket Mehta

3103 silver badges15 bronze badges

Collectives™ on Stack Overflow

Injecting specific implementations using Unity

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related