remove all instances of a character in a string with something else javascript

Question

I need to replace all   with a space. The below is the string that gets spitted out dynamically and i need to hide the br tags...

M,W,Th,F 7:30 AM - 4:00 PM<br />Tu 7:30 AM - 6:00 PM<br />

What am i doing wrong?is it possible to replace all other br tags with a comma except the last one, which will be repalced by a space

$('.WorkingHours').text().replace(/<br />/g, " ");

stackoverflow.com/questions/2145988/jquery-string-replace Answer is here. — PhyBandit
– PhyBandit, Commented Mar 14, 2012 at 14:58

Felix Kling · Accepted Answer · 2012-03-14 15:20:07Z

5

There are three issues with your code:

$('.WorkingHours').text() won't contain any HTML (so no br tags either), it only returns the text content of elements.
$('.WorkingHours').text() returns:

M,W,Th,F 7:30 AM - 4:00 PMTu 7:30 AM - 6:00 PM

whereas $('.WorkingHours').html() returns:

M,W,Th,F 7:30 AM - 4:00 PM Tu 7:30 AM - 6:00 PM 
You have to escape the inner backslash in your expression. Edit: Having a look at the output of .html() it actually does not contain   but  . This might depend on the doctype of the document (not working example, working example).
You have to assign the value back to the element.

You might be able to do

$('.WorkingHours').html(function(i, html) {
    return html.replace(/<br\s*\/?>/g, " "); 
});

but it would be much cleaner to not use regular expressions at all:

$('.WorkingHours').find('br').replaceWith(' ');

This finds all br element nodes and replaces them with a text node containing only a space.

DEMO

Update (in response to one of your comments): If you want to replace the last br with a full stop, you can use .last():

$('.WorkingHours')
 .find('br').last().replaceWith('.')
 .end().replaceWith(' ');

DEMO

edited Mar 14, 2012 at 15:20

answered Mar 14, 2012 at 14:58

Felix Kling

820k181 gold badges1.1k silver badges1.2k bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Selvakumar Arumugam Over a year ago

Shouldn't $('.WorkingHours').find('br').remove() be more appropriate?

Felix Kling Over a year ago

@SKS: I wanted to suggest that, but it won't add a space.

Selvakumar Arumugam Over a year ago

@FelixKling true. missed that space.. my bad.

zzzzBov · Accepted Answer · 2012-03-14 15:00:18Z

1

Couple things:

use html() to get the HTML of the node:

var rawHTML = $('.WorkingHours').html();

Use \ to escape the / within your regex:

/<br \/>/g

Set the HTML to the return value of the replace function:

$('.WorkingHours').html(rawHTML.replace(/<br \/>/g, ' ');

End Product:

var rawHTML = $('.WorkingHours').html();
$('.WorkingHours').html(rawHTML.replace(/<br \/>/g, ' ');

answered Mar 14, 2012 at 15:00

zzzzBov

180k57 gold badges328 silver badges375 bronze badges

Comments

bevacqua · Accepted Answer · 2012-03-14 14:57:07Z

0

using .text() instead of .html() to remove html tags

.text() only returns the inner text, instead of the inner html.

answered Mar 14, 2012 at 14:57

bevacqua

48.8k56 gold badges176 silver badges287 bronze badges

Comments

danwellman · Accepted Answer · 2012-03-14 14:57:10Z

0

I think you need to escape the forward-slash in the expression, e.g.

$('.WorkingHours').text().replace(/<br \/>/g, " ");

answered Mar 14, 2012 at 14:57

danwellman

9,4018 gold badges65 silver badges92 bronze badges

1 Comment

Felix Kling Over a year ago

$('.WorkingHours').text() won't contain any HTML, so no   tags either.

Richard Dalton · Accepted Answer · 2012-03-14 14:58:25Z

0

You need to escape the forward slash in the  :

$('.WorkingHours').text().replace(/<br \/>/g, " ");

http://jsfiddle.net/uLYrH/1

answered Mar 14, 2012 at 14:58

Richard Dalton

35.8k6 gold badges75 silver badges92 bronze badges

2 Comments

Anjana Sharma Over a year ago

how do i find out if it is the last br tag and replace it with "."??

Felix Kling Over a year ago

Your fiddle works because you are working with a string, but $('.WorkingHours').text() won't contain any HTML.

Collectives™ on Stack Overflow

remove all instances of a character in a string with something else javascript

5 Answers 5

3 Comments

End Product:

Comments

Comments

1 Comment

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

3 Comments

End Product:

Comments

Comments

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related