Mixing javascript with c# code with deep nesting. Trying to make external file

Question

I have some javascript and c# code inside one of my views that is deeply nested. Heres the general structure something like this:

@if(something)
{
    <script type="text/javascript">
          @if(something_else)
          {  
                <text>
                    ...some javascript...
                    event: function(){
                       @ViewBag.Property = value;
                    }
                    ...some more javascript... 
                </text>
          }
          @else if(something_else_else)
          {
                 ...some more javascript...
          }
    <script>
}

It works fine in the html file but I would like to put it in an external js file and instead just load like this:

@if(something)
{
    <script type="text/javascript" src="@Url.Content("~Scripts/thescript.js")"></script>
}

However if I try to do this I get error: missing } in XML expression

I tried wrapping the contents in but it still complains with same error. Anybody know if this is possible because its a rather long script and making my view very convoluted.

See Eric's answer. Use partial views instead of js file.

Snake Eyes
– Snake Eyes

2012-03-25 06:51:08 +00:00
Commented Mar 25, 2012 at 6:51 — Snake Eyes
– Snake Eyes, Commented Mar 25, 2012 at 6:51

BenMorel · Accepted Answer · 2014-05-03 22:12:34Z

4

You can use @Html.RazorJSInclude("scriptSource"). Please see the following link

http://djsolid.net/blog/razorjs---write-razor-inside-your-javascript-files

edited May 3, 2014 at 22:12

BenMorel

37k52 gold badges208 silver badges339 bronze badges

answered Mar 25, 2012 at 6:47

Shahriar

752 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Eric J. · Accepted Answer · 2012-03-25 06:36:34Z

2

If I understand you correctly, you're putting code that includes Razor markup in an external .JS file.

The Razor view engine does not parse content in .JS files, so it would not work as you describe.

However, you can greatly clean up your code by using Partial Views where repetitive Razor markup occurs in your view.

answered Mar 25, 2012 at 6:36

Eric J.

151k65 gold badges353 silver badges563 bronze badges

1 Comment

parliament Over a year ago

Ah, yes I dont know how I overlooked to use a partialview. It worked only when wrapped in text blocks like such: <text>@Html.Partial("_PartialView", null)</text> Thank you!

Collectives™ on Stack Overflow

Mixing javascript with c# code with deep nesting. Trying to make external file

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related