summaryrefslogtreecommitdiffstats
path: root/src/corelib/global/qnumeric.cpp
diff options
context:
space:
mode:
authorMatthias Rauter <matthias.rauter@qt.io>2025-05-12 11:02:32 +0200
committerMatthias Rauter <matthias.rauter@qt.io>2025-07-04 13:52:20 +0200
commita671b3b1c88729b6b69c55746116781e2e13b7a1 (patch)
treee7b1e8661e6d7ed0cba7199d05223b6918596be2 /src/corelib/global/qnumeric.cpp
parente186e86599b542930b773bb9eb0f25dfd3dc1857 (diff)
Mark src/corelib/global with security score
Most of the files are unmarked and will therefore fall back to their default value of significant. qendian{_p.h,.h,.cpp} were considered to be critical due to their role in parsers, but ultimately kept at significant. qlogging{.h,.cpp} were considered to be critical because they work with raw string data that might come directly from untrusted sources. However, untrusted string data is forwarded to QString, and string parsing is only performed on trusted strings. Therefore, the security scores are kept at significant. qlibraryinfo.cpp is marked critical because it influence paths from which libraries and executables are loaded. qnumeric{.h,.cpp} are marked critical because they handle edge-cases that might lead to undefined behaviour if not handled correctly. At the current point we assume that various data-parsers rely on the correct behavior of these functions and therefore want to treat them as critical. qrandom{.h,.cpp} are marked critical because they are related to cryptography. Some functionality is described as cryptographically safe in the documentation. While we forward the complex parts to the OS, it seems prudent to be extra cautious here. QUIP: 23 Pick-to: 6.10 6.9 6.8 Fixes: QTBUG-135186 Change-Id: I037379fff3a72c36b840d042252391417de33f5c Reviewed-by: Axel Spoerl <axel.spoerl@qt.io> Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
Diffstat (limited to 'src/corelib/global/qnumeric.cpp')
-rw-r--r--src/corelib/global/qnumeric.cpp1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/corelib/global/qnumeric.cpp b/src/corelib/global/qnumeric.cpp
index 16b2b7ca408..8b153bcdb84 100644
--- a/src/corelib/global/qnumeric.cpp
+++ b/src/corelib/global/qnumeric.cpp
@@ -1,5 +1,6 @@
// Copyright (C) 2019 The Qt Company Ltd.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only
+// Qt-Security score:critical reason:data-parser
#include "qnumeric.h"
#include "qnumeric_p.h"