summaryrefslogtreecommitdiffstats
path: root/src/corelib/tools/qarraydata.cpp
diff options
context:
space:
mode:
authorMarc Mutz <marc.mutz@qt.io>2023-12-12 20:51:56 +0100
committerMarc Mutz <marc.mutz@qt.io>2023-12-13 21:54:00 +0100
commit658607a34ead214fbacbc2cca44915655c318ea9 (patch)
tree929c4f0b0b892ef1ed9916b74c8fb3f71f5fd82b /src/corelib/tools/qarraydata.cpp
parent46923f2648ba99b3d070ea077f04047172ba4923 (diff)
HPack: fix a Yoda Condition
Putting the variable on the LHS of a relational operation makes the expression easier to read. In this case, we find that the whole expression is nonsensical as an overflow protection, because if name.size() + value.size() overflows, the result will exactly _not_ be > max() - 32, because UB will have happened. To be fixed in a follow-up commit. As a drive-by, add parentheses around the RHS. Pick-to: 6.7 6.6 6.5 6.2 5.15 Change-Id: I35ce598884c37c51b74756b3bd2734b9aad63c09 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'src/corelib/tools/qarraydata.cpp')
0 files changed, 0 insertions, 0 deletions