summaryrefslogtreecommitdiffstats
path: root/src/gui/opengl/qopenglprogrambinarycache_p.h
diff options
context:
space:
mode:
authorThiago Macieira <thiago.macieira@intel.com>2022-06-22 14:01:13 -0700
committerThiago Macieira <thiago.macieira@intel.com>2022-06-24 19:05:57 -0700
commit0978646a65f517f0026fbdd0639415d265876512 (patch)
treef1d8144cde4185c31438ec6a4b33de394fddcb07 /src/gui/opengl/qopenglprogrambinarycache_p.h
parent3816b14ee8bc6f9722f3b76a32f968e334d0ed27 (diff)
moc: remove the attempt to create one large string literal
Commit dda9c9e2bc4fd2efe9e3fb0e451a8c3512f9a4d2 fixed some outstanding issues with moc's calculation of the maximum string length, but it missed one. This commit instead opts to remove the calculation entirely and instead have multiple char array members in the qt_meta_stringdata. We needed a single string back in Qt 4.0 when the stringdata *was* a single char array. Since 5.0, we've used a structure with multiple members and pointer arithmetic going past the end of the arrays, from the top of the object. That's UB, but since it's always been UB and can't be fixed until Qt 7 anyway, let's go full monty on it and have one char array per meta object string. The struct qt_meta_stringdata_Qt_t for namespace Qt now has 1217 stringdataXXX members. Pick-to: 6.2 6.3 6.4 Change-Id: I6d3880c7d99d4fc494c8fffd16fb0d1573e387dc Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Diffstat (limited to 'src/gui/opengl/qopenglprogrambinarycache_p.h')
0 files changed, 0 insertions, 0 deletions