Clarification on how to accept commit access requests

LLVM Project
1

RFC: Change the process for requesting commit access recently changed how users request commit access. I really appreciate that the process is public, well documented, and integrated into GitHub.

However, I feel it could use some clarification on how users are suppose to accept these requests (example: Request Commit Access For int3 · Issue #165339 · llvm/llvm-project · GitHub). I found LLVM Developer Policy — LLVM 22.0.0git documentation where it says:

Reviewers of your committed patches will automatically be CCed upon creating the issue. Most commonly these reviewers will provide the necessary approval, but approvals from other LLVM committers are also acceptable. Those reviewing the application are confirming that you have indeed had three patches committed, and that based on interactions on those reviews and elsewhere in the LLVM community they have no concern about you adhering to our Developer Policy and Code of Conduct.

Does this mean commenting something like “I approve of this request” is sufficient? Can this be clarified? Also, can we add a link to these docs in the issue itself?

2

In my experience yes, but it would be good to make this clearer so that the admins don’t have to interpret more vague phrasing. Something like “reviewers should make clear their reasoning for accepting or rejecting a request, and finish with a clear statement such as I approve of this request or I do not approve of this request”.

This file is responsible (via. a bunch of workflow magic) for that.

I suppose by the time the issue has been raised, the policy link is more useful to approvers than the submitter, who presumably read it already. So it could go in the second comment that shows the PR activity.

1 Like