Exception enhancements #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gorithm_HTTP response failure handling (for 5xx errors).
…gorithm_HTTP response failure handling (for 5xx errors).
zeryx
commented
Jun 21, 2021
| def create_algo_response(responseJson): | ||
| # Parse response JSON | ||
| if 'error' in responseJson: | ||
| def create_algo_response(response): |
Contributor
Author
There was a problem hiding this comment.
This has been renamed, because the response might not be json
zeryx
commented
Jun 21, 2021
| response = self.requestSession.post(self.apiAddress + url, data=input_json, headers=headers, params=query_parameters) | ||
|
|
||
| if parse_response_as_json: | ||
| if parse_response_as_json and response.status_code == 200: |
Contributor
Author
There was a problem hiding this comment.
checks to ensure that the response is 200; which our API servers always set, but if there's a failure along the path we might not be able to deserialize as json
kennydaniel
approved these changes
Jun 21, 2021
Contributor
kennydaniel
left a comment
There was a problem hiding this comment.
That looks much better 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated logic from #84
ran into some complications in a previous PR; but changelog looks pretty clean now, unsure how to fix whitespace issue easily but testing is completely functional.