fix(pkg/board): consume zombie process in adb #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martacarbone
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some ADB operations didn't call .wait, which creates a zombie process in mac/linux
Change description
Add the missing .Wait function 🥲.
Additional Notes
The number of processes used by AppLab is continuously increasing due to a missing wait() call on the os resources.
This causes the following error when the maximum number of open processes is reached:
# zsh: fork failed: resource temporarily unavailableThis PR add a wait() to the ReadWriteCloser, so the os processes can be cleaned up.
Reviewer checklist
main.