Fix Coder connect workflows #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fioan89
commented
Feb 24, 2025
- fixes login screen and glitches related jumping to the workspaces page once the connection to Coder deployment is estabilished.
- support for opening URLs in browser
- fixes user agent reporting
- fixes connection status rendering
- will also reflect on the jar/zip name
- copied from coder gateway plugin
- the API for browsing url(s) is no longer available - this patch implements a basic URL opener that relies on native tools.
- if successfully signed in we go back to the main page which shows the environments/workspaces - similar approach if user hits Cancel during sign in - `EnvironmentUiPageManager` is an undocumented Toolbox component that has more flexibility to navigate between pages
- the connection status was unreadable due to the background and foreground colors used. The latest Toolbox version comes with standard color palettes that change based on the theme and environment state. - plus some small extra refactorings that reduce the number of constructor parameters and rely on the service locator
- url was not displayed in the env page until the rest client was connected - but we don't need to wait for the rest client to connect, the url is already available from settings
- Toolbox does not provide a plugin manager interface with metadata about current plugin. So we had to implement one for ourselves in order to have simple things like plugin version. - the implementation relies on the extension.json which is deployed in the root of the jar (i.e. the plugin jar) - the rest of the json fields are ignored for now
- use plugin's version
matifali
reviewed
Feb 25, 2025
| val dir = env.get("XDG_DATA_HOME") | ||
| if (dir.isNotBlank()) { | ||
| return Paths.get(dir, "coder-gateway") | ||
| return Paths.get(dir, "coder-toolbox") |
Member
There was a problem hiding this comment.
I think we should drop the toolbox suffix here. There is nothing like a Coder toolbox. The coder is part of the JetBrains toolbox.
Collaborator
Author
There was a problem hiding this comment.
We can probably do it as long as we're sure we are not overlapping (now or in the future) with coder cli manually installed.
Member
There was a problem hiding this comment.
Hmm. I will then keep the prefix. I was not sure what it was for.
@bcpeinhardt and @f0ssel may have more context here,
matifali
reviewed
Feb 25, 2025
Member
matifali
left a comment
There was a problem hiding this comment.
A general comment abut using the -toolbox suffix.
@bcpeinhardt can review the code better.
matifali
approved these changes
Feb 26, 2025
Member
matifali
left a comment
There was a problem hiding this comment.
@bcpeinhardt I am approving to unblock so that we can keep moving frward.
fioan89
added a commit
that referenced
this pull request
Nov 3, 2025
This PR addresses two issues in the URI handler workflow to improve user experience and reliability. 1. Streamline version fallback behavior Problem: When the URI handler receives a build number that is no longer available, the application would fall back to the latest version but display a confirmation dialog. Netflix reported that this confirmation dialog disrupts the user workflow. Solution: Removed the confirmation dialog and replaced it with logging. The handler now silently falls back to the latest available version when the requested build number is unavailable, maintaining a seamless user experience. 2. Fix connect page not displaying when Toolbox is already open Problem: When Toolbox is already running and a URI is executed, the connect page fails to display. Investigation revealed that the UI event emitted via MutableSharedFlow(replay = 0) is lost because the UI collector is not yet active when processEvent() is called. Solution: Introduced a 66-100ms delay before emitting the UI event. This delay ensures the collector is ready to receive events, preventing them from being dropped. The timing was determined through testing and appears to account for the collector initialization time. Note: The delay in fix #2 is a workaround for what appears to be a timing issue with the MutableSharedFlow collector initialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.