Skip to content

Conversation

@code-asher
Copy link
Member

Fixes #188.

Would like to add a test but I still need to figure out how to get UI tests running.

The import change was done automatically by Intellij. Not sure about the reasoning behind it.

@code-asher code-asher requested a review from johnstcn April 3, 2023 18:04
@fioan89
Copy link
Collaborator

fioan89 commented Apr 3, 2023

UI testing is indeed a complex topic. I actually avoided to write anything as it was too much time consuming. At the time it was much faster to do some manual smokes. But I guess it now makes sense, too many scenarios to do manually.

If it's any help you could start here: https://plugins.jetbrains.com/docs/intellij/testing-plugins.html

import com.coder.gateway.sdk.v2.models.WorkspaceTransition
import java.util.UUID
import java.util.*
import javax.swing.Icon
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably because of your default code style configuration. I think I mentioned in the past that by default, IntelliJ is set to collapse the imports of you have more than 3 references from the same package. However the general practice in the Java/Kotlin community is to use explicit imports.

In the end it's just a matter of taste.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhhhhhhhhhh that explains a lot hahaha. I will configure it for explicit imports; I definitely want to stick to general practices.

@code-asher
Copy link
Member Author

code-asher commented Apr 3, 2023

Thank you for the link! I will check it out and get up some UI tests in a future PR.

@code-asher code-asher merged commit d2bca87 into main Apr 3, 2023
@code-asher code-asher deleted the fix-table-refresh branch April 3, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

no way to refresh workspace list

2 participants