🤖 refactor: move compaction logic to backend #670
+1,224
−394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b186d47 to
7d2df23
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
7d2df23 to
2b2b2fc
Compare
Member
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Member
Author
|
@codex review |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
eeafe28 to
1eda7a1
Compare
Move history compaction handling from WorkspaceStore to agentSession to centralize server-side operations. Backend changes: - Added handleCompactionCompletion() to detect and handle compaction stream-end events - Added handleCompactionAbort() to handle Ctrl+A (accept early with [truncated]) and Ctrl+C (cancel) flows - Added performCompaction() to atomically replace chat history with summary message - Added processedCompactionRequestIds Set to dedupe repeated compaction events - Implemented abandonPartial flag flow from IPC through to StreamAbortEvent - Extract truncated message content from history instead of partialService - Wrap compaction handlers in try-catch to ensure stream events always forwarded - Made performCompaction return Result type for proper error handling Frontend changes: - Removed compaction handlers from WorkspaceStore - Simplified cancelCompaction() to just call interruptStream with abandonPartial flag - Fixed Ctrl+A keybind to pass abandonPartial: false for early accept Shared changes: - Updated StreamAbortEvent to include abandonPartial flag - historyService.clearHistory() now returns deleted sequence numbers - Created calculateCumulativeUsage() utility to extract and sum usage from messages - aiService respects abandonPartial flag - skips committing when true
1eda7a1 to
4560627
Compare
ammario
requested changes
Nov 18, 2025
Move compaction handling from agentSession to dedicated CompactionHandler class. Changes: - Created src/node/services/compactionHandler.ts with CompactionHandler class - Extracted handleAbort, handleCompletion, and performCompaction methods - Updated agentSession.ts to delegate to CompactionHandler - Moved frontend compaction handler to browser utils - Reduced agentSession.ts from 764 to 589 lines Benefits: - Better separation of concerns - Easier to test compaction logic independently - Cleaner session orchestration code _Generated with `mux`_
ethanndickson
commented
Nov 19, 2025
|
|
||
| // Wait for first stream to complete | ||
| const collector1 = createEventCollector(env.sentEvents, workspaceId); | ||
| await collector1.waitForEvent("stream-end", 30000); |
Member
Author
There was a problem hiding this comment.
This was flaking on Thomas' PRs too, so I've bumped the timeout
This was referenced Nov 20, 2025
ibetitsmike
reviewed
Nov 20, 2025
ibetitsmike
reviewed
Nov 20, 2025
ibetitsmike
requested changes
Nov 20, 2025
Contributor
ibetitsmike
left a comment
There was a problem hiding this comment.
lgtm but I'd add some testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated with
muxStack
Summary
Moves history compaction handling from WorkspaceStore (frontend) to agentSession (backend) to centralize server-side operations and fix race conditions.
Relates to #651.
Changes
Backend (agentSession.ts)
handleCompactionCompletion()- detects compaction stream-end, extracts summary from event.parts, performs history replacementhandleCompactionAbort()- handles Ctrl+A (accept early with[truncated]) and Ctrl+C (cancel) flowsperformCompaction()- atomically replaces chat history with summary message including cumulative usageabandonPartialflag flow from IPC through to StreamAbortEventFrontend (WorkspaceStore.ts)
handleCompactionCompletion()andhandleCompactionAbort()methodsperformCompaction()methodprocessedCompactionRequestIdsSetcancelCompaction()- just callsinterruptStreamwithabandonPartial: trueabandonPartial: falsefor early acceptShared
StreamAbortEventto includeabandonPartial?: booleanhistoryService.clearHistory()now returns deleted sequence numberscalculateCumulativeUsage()utility indisplayUsage.tsto extract and sum usage from messagesTesting
/compactcompletes successfully[truncated]