use rems for font sizes #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argemiront
reviewed
Jan 24, 2020
Member
argemiront
left a comment
There was a problem hiding this comment.
Still having the same problem here. The extension is on fix/font-sizes and the folder was cleaned before the new one was loaded.
Member
Author
|
Font sizes seem to adjust for me. I wonder what the difference is.
|
Member
|
The font changes size according to the zoom level. It's just the relation between the UI and the font size in my case. It works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #78
This will make font sizes in the extension the same as in the editor. May be considered a fix?