Obsolete PWMRANGE still defined as LITERAL1 in keywords.txt #8447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PWMRANGE was defined up until v2.7.4: ``` $ cd ~/Library/Arduino15/packages/esp8266/hardware/esp8266 $ grep -R "PWMRANGE" 2.7.4 2.7.4/keywords.txt:PWMRANGE LITERAL1 2.7.4/tests/host/common/Arduino.h:#define PWMRANGE 1023 2.7.4/cores/esp8266/core_esp8266_wiring_pwm.cpp:static int32_t analogScale = PWMRANGE; 2.7.4/cores/esp8266/Arduino.h:#define PWMRANGE 1023 ``` The define was removed in favour of the Arduino standard value of 255 but the keyword coloring was left behind: ``` $ cd ~/Library/Arduino15/packages/esp8266/hardware/esp8266 $ grep -R "PWMRANGE" 3.0.2 3.0.2/keywords.txt:PWMRANGE LITERAL1 ``` In the Arduino IDE, the coloring makes it look like PWMRANGE still exists, when it doesn't, which is confusing. Signed-off-by: Phill Kelley <pmk.57t49@lgosys.com>
earlephilhower
approved these changes
Jan 11, 2022
Collaborator
earlephilhower
left a comment
There was a problem hiding this comment.
Good catch, thanks!
hasenradball
pushed a commit
to hasenradball/Arduino
that referenced
this pull request
Nov 18, 2024
PWMRANGE was defined up until v2.7.4: ``` $ cd ~/Library/Arduino15/packages/esp8266/hardware/esp8266 $ grep -R "PWMRANGE" 2.7.4 2.7.4/keywords.txt:PWMRANGE LITERAL1 2.7.4/tests/host/common/Arduino.h:#define PWMRANGE 1023 2.7.4/cores/esp8266/core_esp8266_wiring_pwm.cpp:static int32_t analogScale = PWMRANGE; 2.7.4/cores/esp8266/Arduino.h:#define PWMRANGE 1023 ``` The define was removed in favour of the Arduino standard value of 255 but the keyword coloring was left behind: ``` $ cd ~/Library/Arduino15/packages/esp8266/hardware/esp8266 $ grep -R "PWMRANGE" 3.0.2 3.0.2/keywords.txt:PWMRANGE LITERAL1 ``` In the Arduino IDE, the coloring makes it look like PWMRANGE still exists, when it doesn't, which is confusing. Signed-off-by: Phill Kelley <pmk.57t49@lgosys.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PWMRANGE was defined up until v2.7.4:
The define was removed in favour of the Arduino standard value of 255
but the keyword coloring was left behind:
In the Arduino IDE, the coloring makes it look like PWMRANGE still
exists, when it doesn't, which is confusing.
Signed-off-by: Phill Kelley pmk.57t49@lgosys.com