Skip to content

Fix console URL for RTDB commands #2801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2020
Merged

Fix console URL for RTDB commands #2801

merged 2 commits into from
Nov 9, 2020

Conversation

@sarajmunjal
Copy link
Contributor

@sarajmunjal sarajmunjal commented Nov 9, 2020 •
edited
Loading

Description

For database:set|update|push, display the correct console URL.
This accounts for two things:-

  1. New RTDB URLs
  2. Projects with multiple instances

Scenarios Tested

firebase database:push /path/ --instance <instance> --project=<project> -d `"hello123"'
firebase database:set /path/ --instance <instance> --project=<project> -d `"hello123"'
firebase database:update /path/ --instance <instance> --project=<project> -d '{"cliKey":"hello123"}'

both with and without FIREBASE_CLI_PREVIEWS=rtdbmanagement

Screenshot for reviewers: https://screenshot.googleplex.com/3vrk348acHuPdTd

@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Nov 9, 2020
@sarajmunjal sarajmunjal requested a review from yuchenshi November 9, 2020 21:08
@sarajmunjal sarajmunjal merged commit 0578967 into master Nov 9, 2020
@sarajmunjal sarajmunjal deleted the saraj/rtdb-view-url-fix branch November 9, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuchenshi yuchenshi yuchenshi approved these changes

Assignees

@yuchenshi yuchenshi

Labels

cla: yes Manual indication that this has passed CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sarajmunjal @yuchenshi