Skip to content

Modules, introduction #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2020
Merged

Modules, introduction #198

merged 2 commits into from
May 27, 2020

Conversation

@EzequielCaste
Copy link
Contributor

@EzequielCaste EzequielCaste commented May 19, 2020

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team May 19, 2020 22:52
@javascript-translate-bot
Copy link

javascript-translate-bot commented May 19, 2020

Error: the article already has PR number in the Progress Issue #17, it's 197 ⁉️

@iliakan iliakan mentioned this pull request May 19, 2020
Open
joaquinelio
joaquinelio approved these changes May 25, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me gusta.
Me gustarían algunos cambios pero es gusto personal o cosas que no hacen al JS...

y tenemos 70 y pico de PR por meter, el doble de review

@EzequielCaste EzequielCaste merged commit 4ad4b7f into javascript-tutorial:master May 27, 2020
@javascript-translate-bot
Copy link

javascript-translate-bot commented May 27, 2020

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

@joaquinelio
Copy link
Member

joaquinelio commented May 27, 2020

@ezzep66 ¡Qué emoción!
log

Una cosita... El bot sugiere 2 reviewers (quedó colgado el status needs+1) , cmo maintainer es tu prerrogativa no hacerle caso ¿vamos a trabajar así?
Por mí BIEN, prefiero que se filtre algún errorcito a ver que diluye por falta de interés como el año pasado. Además cuando se termine el resto se pueden revisar los PR cerrados ver cuál necesita rechequeo, no me preocupa.

Era deprimente el mensaje "last commit" parado un año. Podemos decir que avanza,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EzequielCaste @javascript-translate-bot @joaquinelio