Skip to content

Shadow DOM #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 7, 2020
Merged

Shadow DOM #386

merged 3 commits into from
Oct 7, 2020

Conversation

@joaquinelio
Copy link
Member

@joaquinelio joaquinelio commented Sep 22, 2020

y sombras serán

No pude traducir las herramientas de chrome porque lo tengo en inglés:
More tools > developer tools > (engranaje) > show user agent shadow dom
agregárelo quien pudiere

@javascript-translate-bot javascript-translate-bot requested a review from a team September 22, 2020 05:09
@javascript-translate-bot javascript-translate-bot mentioned this pull request Sep 22, 2020
Open
vplentinax
vplentinax requested changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¿En qué línea está lo que dices?

@javascript-translate-bot
Copy link

javascript-translate-bot commented Sep 23, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@joaquinelio @vplentinax
Apply suggestions from code review
c29ea2e 
Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>
@joaquinelio
Copy link
Member Author

joaquinelio commented Sep 23, 2020 •
edited
Loading

linea 15
necesitamos habilitar la opción "Show user agent shadow DOM" en "herramientas".

Supongo, que es "herramientas", supongo que es "herramientas de desarrollo"
pero no queria adivinar "Show user agent shadow DOM"

ah, done
=)

@joaquinelio
Copy link
Member Author

joaquinelio commented Sep 23, 2020

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team September 23, 2020 17:57
vplentinax
vplentinax requested changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si, en las herramientas de desarrollo.

@javascript-translate-bot
Copy link

javascript-translate-bot commented Oct 7, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@joaquinelio @vplentinax
"herramientas de desarrollo"
ea751c2 
Ok.
¿buscaste "Show user agent shadow DOM"?

Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>
@joaquinelio
Copy link
Member Author

joaquinelio commented Oct 7, 2020

Ok.
¿buscaste "Show user agent shadow DOM"?

@vplentinax
Copy link
Contributor

vplentinax commented Oct 7, 2020 •
edited
Loading

Haz merge, ya que tu eres como el segundo "reviwer" y así avanzamos más.

@joaquinelio
Copy link
Member Author

joaquinelio commented Oct 7, 2020

Es que me había entusiasmado ahora que parecía concurrido...

Pero está, bien, el procedimiento lo permite.

@joaquinelio joaquinelio merged commit c24c603 into javascript-tutorial:master Oct 7, 2020
@javascript-translate-bot
Copy link

javascript-translate-bot commented Oct 7, 2020

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

@joaquinelio joaquinelio deleted the shadows branch October 7, 2020 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vplentinax vplentinax vplentinax requested changes

Assignees

No one assigned

Labels

changes requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joaquinelio @javascript-translate-bot @vplentinax