Support mirror clone

[Aimeast]

Hi,

I want a choose that can clone repository with --mirror. Maybe this one not supported by libgit2 yet.

https://github.com/libgit2/libgit2/blob/5bfead1dba919f6b47f52da675ea94407e8baf49/include/git2/clone.h#L48-L58

[nulltoken]

Unless I'm wrong this is not supported yet. @ben can you confirm?

[carlosmn]

A mirror-clone doesn't need special support from the library. It is a "normal" clone, except that the remote has a fetch refspec of +refs/*:refs/* and remote.origin.mirror is set to true which only affects push. git-core will also assume you meant to use a bare repo and use the standard extension for it.

The library lets you initialize a repo (git_repository_init(), save a remote with said fetch refspec git_remote_new_with_fetchspec() and perform the rest of the clone git_clone_into(). There is currently no support for the special behaviour that remote.<name>.mirror invokes, but that's often quite minor (and arguably an UI feature we shouldn't hard-wire). You'd also have to set remote.origin.mirror to true, but the API lets you do that as well.

[Aimeast]

@carlosmn Thanks for you advise, it's working!

@nulltoken Does libgit2sharp not supported remove a remote?

using (var repo = new Repository(Repository.Init(@"path\to\local.git", true)))
{
    var remote = repo.Network.Remotes.Add("origin", "path\to\remote.git", "+refs/*:refs/*");
    repo.Network.Fetch(remote /* anything for report progress */);
    //repo.Network.Remotes.Remove(remote); // not supported by lg2s?
}

[nulltoken]

@nulltoken Does libgit2sharp not supported remove a remote?

See @Yogu's #567 which should allow one to manipulate default remote refspecs

[Aimeast]

@nulltoken Good! This issue to be closed after #567.

[Aimeast]

Opps, looks like the commit b51570e still not introduce the API Remove.
libgit2 has no API like git_remote_remove defined?

How to remove a remote by libgit2sharp?

/cc @nulltoken @carlosmn

[carlosmn]

It doesn't have it yet.

[nulltoken]

@Aimeast I previously mis-read your question. Sorry for that. #567 was only about manipulating refspecs.

you can track git_remote_delete() progress with libgit2/libgit2#1199

[Aimeast]

@nulltoken @carlosmn Thanks.

It looks like #1199 is closed. Can this issue be closed now? @Aimeast @nulltoken

[nulltoken]

@MrTomWhite Indeed. Thanks for pointing out to this. It's been made available in LibGit2Sharp through #731

Closing this now, then