fix: simplify streaming of server writes #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for blobs-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Skn0tt
previously approved these changes
Jan 15, 2024
Skn0tt
approved these changes
Jan 15, 2024
orinokai
approved these changes
Jan 15, 2024
orinokai
left a comment
There was a problem hiding this comment.
this seems like it should help, thanks @eduardoboucas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this pull request solving?
We've seen some intermittent failures when handling
set()calls in the Blobs server, where we seem to write a zero-bytes file to the final location.This PR attempts to solve that by simplifying the logic for handling the streaming of these requests, replacing
pipe()with the betterpipeline().