feat: add setFiles() method
#28
Conversation
✅ Deploy Preview for blobs-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Skn0tt
left a comment
There was a problem hiding this comment.
Looks good generally, left some notes.
package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "esbuild": "0.18.17" | ||
| "esbuild": "0.18.17", |
There was a problem hiding this comment.
should esbuild be listed as a prod dependency?
There was a problem hiding this comment.
Definitely not! Moved to devDependencies in 43b40b6.
src/main.ts
Outdated
| const payload = JSON.stringify(data) | ||
| const headers = { | ||
| ...Blobs.getTTLHeaders(ttl), | ||
| ...Blobs.getExpirationeaders(expiration), |
There was a problem hiding this comment.
| ...Blobs.getExpirationeaders(expiration), | |
| ...Blobs.getExpirationHeaders(expiration), |
this typo is also in a bunch of other places
| "dependencies": { | ||
| "esbuild": "0.18.17" | ||
| "esbuild": "0.18.17", | ||
| "p-map": "^6.0.0" |
There was a problem hiding this comment.
Have you tested this with Edge Functions?
There was a problem hiding this comment.
Not yet, but I know that introducing a npm module will change the game. My plan is to stop publishing a Deno module from this repo and instead load the Node.js module into the bootstrap layer using https://esm.sh. We're vendoring the module anyway, so it shouldn't matter whether we vendor it from Netlify or an external source.
Which problem is this pull request solving?
Adds a
setFiles()method, which lets consumers write multiple keys from files concurrently, with a configurable concurrency level.It also renames the
ttltoexpiration, because I feel it's clearer and more accurate.I've also done a pretty large refactoring of the test suite, adding a
MockFetchutility that simplifies the tests, and adding tests for the edge flow.For this reason, I recommend reviewing the commits separately.