Skip to content

Implement optimizer_hints using OPTION clause #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 31, 2021
Merged

Implement optimizer_hints using OPTION clause #865

merged 5 commits into from
Mar 31, 2021

Conversation

@mgrunberg
Copy link
Contributor

@mgrunberg mgrunberg commented Mar 30, 2021

This PR resolves #856. As the issue suggests, optimizer_hints just deals with query hints

Inspired by the Mysql & Postgres adapters, the following are equivalent:

Model.optimizer_hints("OPTION (MAXDOP 2, FAST 1)")
Model.optimizer_hints("MAXDOP 2, FAST 1")
Model.optimizer_hints("MAXDOP 2", "FAST 1")

@aidanharan aidanharan mentioned this pull request Mar 31, 2021
Closed
wpolicarpo
wpolicarpo requested changes Mar 31, 2021
View reviewed changes
@mgrunberg mgrunberg requested a review from wpolicarpo March 31, 2021 17:53
@wpolicarpo
Copy link
Member

wpolicarpo commented Mar 31, 2021

Thanks for you contribution!

@wpolicarpo wpolicarpo merged commit 2bf0078 into rails-sqlserver:master Mar 31, 2021
@mgrunberg mgrunberg deleted the issues/yellowspot/856_missing_optimizer_hints_implementation branch January 3, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wpolicarpo wpolicarpo Awaiting requested review from wpolicarpo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing proper implementation for Rails 6 optimizer_hints

2 participants

@mgrunberg @wpolicarpo