(clean up) Separate generated command flags registry initialisation from actual implementation #4345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uglide
added a commit
that referenced
this pull request
Nov 5, 2025
* Add commands flags based on static map * Clean up CommandFlagsRegistryGenerator * more fixes to CommandFlagsRegistryGenerator * Introduce CommandFlagsRegistry interface - Add new interface and move CommandFlag enum there - Generate StaticCommandFlagsRegistry instead of embedding generated code into CommandObject - Allow passing custom CommandFlagsRegistry to ClusterClientBuilder * Fix formatting * Add support for sub-commands * Use CommandArguments in the interface and hierarchical approach in static registry * Expose get() on CommandArguments for cleaner code * Use byte array based look up to improve performance * (clean up) Separate generated command flags registry initialisation from actual implementation (#4345) * (clean up) Extract generated registry initialization * regenerate after clean up * reformat * Clean up StaticCommandFlagsRegistry --------- Co-authored-by: Ivo Gaydazhiev <ivo.gaydazhiev@redis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.