Update dependencies and support running in browser #228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
npm audit fix --forcenode-rsaout of the box without having to do polyfilling themselves.This includes changes from @learntheropes 's fork for running node-rsa in the browser out of the box. The main thing their fork does is use the buffer package instead of assuming
Bufferwas available. Their fork did not make this a conditional change, which means someone using@learntheropes/node-rsain node will end up using the npm package rather than the node one. My changes address this.