Coverage information say's that an ending curly is dead not covered

[cmodijk]

For this simple function the ending curly brace is detected as dead code. I think it has something to do with the finally part but i'm not sure.

class Unzip
{
    public function extractFile()
    {
        try {
            return true;
        } finally {
            echo 'Do somthing';
        }
    }
}

The test case

class UnzipTest extends \PHPUnit_Framework_TestCase
{
    public function testUnzip()
    {
        $unzip = new Unzip();
        $this->assertTrue($unzip->extractFile());
    }
}

Versions

• Xdebug: v2.3.3
• phpunit: 4.8.21
• PHP: 5.6.16

[sebastianbergmann]

Looks like an edge case to me. @derickr?

[derickr]

Nope - it's not an edge case. It's because Xdebug doesn't understand the "FAST_CALL" opcode that is used for finally - and hence doesn't do proper branch and dead code analysis.

[derickr]

See: http://bugs.xdebug.org/view.php?id=1241 - and it's also a problem with https://github.com/derickr/vld

[dereckson]

The same issue occurs when a method throws an exception, like abort in the Laravel framework.

if (!$this->isLegitRequest()) {
    abort(403, 'Unauthorized action.');
}

Two tests hit this code block, one legit, one not legit, the final } is noted not executed.

[mindplay-dk]

Upgrading to xdebug 2.4 stable fixed this issue for me.

@sebastianbergmann I think you can close this?

[cmodijk]

Not for me i just upgraded everything and still the same i created this example repo

git clone https://github.com/cmodijk/phpunit-fast-call-example.git
cd phpunit-fast-call-example
composer install
./vendor/bin/phpunit -c . --coverage-html=coverage

php -v 

PHP 5.6.20 (cli) (built: Mar 31 2016 17:14:52) 
Copyright (c) 1997-2016 The PHP Group
Zend Engine v2.6.0, Copyright (c) 1998-2016 Zend Technologies
    with Zend OPcache v7.0.6-dev, Copyright (c) 1999-2016, by Zend Technologies
    with Xdebug v2.4.0, Copyright (c) 2002-2016, by Derick Rethans

I also tried php 7

php -v

PHP 7.0.4 (cli) (built: Mar 13 2016 20:10:05) ( NTS )
Copyright (c) 1997-2016 The PHP Group
Zend Engine v3.0.0, Copyright (c) 1998-2016 Zend Technologies
    with Zend OPcache v7.0.6-dev, Copyright (c) 1999-2016, by Zend Technologies
    with Xdebug v2.4.0, Copyright (c) 2002-2016, by Derick Rethans

[derickr]

@cmodijk - I can reproduce that. It's the bloody FAST_CALL/FAST_RET stuff for finally again. I'm mailing @nikic again as he's tried explaining this to me before :-)

[nikic]

@derickr For FAST_CALL, add opline+1 as a possible branch target. Doesn't exactly reflect reality, but should be good enough for this purpose.

[derickr]

Hey @nikic, that seems to do the trick. I'll cook up a patch soon enough.