Code Coverage report stops after anonymous function if last in class #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… class would cause the coverage report to ignore the rest of the lines in the parent method of the anonymous functions. With tests.
sebastianbergmann
added a commit
that referenced
this pull request
Jun 12, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an existing issue for this: #152
And some more discussion about it from the PHP_TokenStream project: sebastianbergmann/php-token-stream#28 (comment)
The fix used here comes from that comment from @edorian. Spent a good chunk of the day tracking down where the issue was, creating a couple of different tests to help dig.
Ultimately the Clover test I added is probably unnecessary, since the root of the problem ended up being in PHP_CodeCoverage_Util::getLinesToBeIgnored (which I also created a test for). I left the clover test in place though.